Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete old redundant encryption MDX file #21834

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

rmainwork
Copy link

@rmainwork rmainwork commented Oct 16, 2024

Description

This file path (security/encryption.mdx updated a year ago) is conflicting with another file path (security/encrpytion/index.mdx updated 2 weeks ago).

This is causing the Vercel build to fail since the GitHub runner cannot distinguish between the file encryption.mdx and the path
encryption/index.mdx

This file specifically was chosen for deletion in preference to the other due to it being more recently updated.

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

This file path (`security/encryption.mdx` updated a year ago) is conflicting
with another file path (`security/encrpytion/index.mdx` updated 2 weeks
ago). This is causing the Vercel build to fail since the GitHub runner
cannot distinguish between the file `encryption.mdx` and the path
`encryption/index.mdx`

This one specifically was chosen for deletion due to it last being
updated a year ago vs `encryption/idex.mdx` being updated 2 weeks ago
@rmainwork rmainwork requested a review from a team as a code owner October 16, 2024 13:40
@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Oct 16, 2024
@zalimeni
Copy link
Member

zalimeni commented Oct 16, 2024

It looks like the older file was removed in #21509, but that PR backported to release/1.19.x, and not release/1.20.x, so this seems correct to me - but probably needs the entire PR backported, not just this removal?

@boruszak just double checking, is it expected that we didn't backport the original PR's refactor to release/1.18.x and release/1.15.x (LTS)?

@boruszak
Copy link
Contributor

Thanks for the callout @zalimeni! We should backport this to v1.15 and v1.18 as well.

@zalimeni zalimeni merged commit c25549f into release/1.20.x Oct 16, 2024
102 of 103 checks passed
@zalimeni zalimeni deleted the rm/delete-old-encryption-file branch October 16, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-backport type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants