Skip to content

Commit

Permalink
fix: Reverting border-radius update, and using overflow hidden on tag
Browse files Browse the repository at this point in the history
  • Loading branch information
dchyun committed Jan 3, 2025
1 parent c512daa commit 9730dde
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

// Copied from components/src/styles/components/tag.scss styles
// we set a higher value than the line-height (~13px) to accommodate cases where the text wraps
$hds-tag-border-radius: 20px; // This variable is repeated from tag.scss
$hds-tag-border-radius: 50px; // This variable is repeated from tag.scss
$hds-super-select-item-height: 36px;

// Style overrides:
Expand Down
8 changes: 7 additions & 1 deletion packages/components/src/styles/components/tag.scss
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
@use "../mixins/focus-ring" as *;

// we set a higher value than the line-height (~13px) to accommodate cases where the text wraps
$hds-tag-border-radius: 20px;
$hds-tag-border-radius: 50px;

.hds-tag {
display: inline-flex;
Expand All @@ -20,6 +20,12 @@ $hds-tag-border-radius: 20px;
background-color: var(--token-color-surface-interactive);
border: 1px solid var(--token-color-border-strong);
border-radius: $hds-tag-border-radius;
overflow: hidden;
}

.hds-tag:focus-within,
.hds-tag:has(.mock-focus) {
overflow: visible;
}

.hds-tag__dismiss {
Expand Down

0 comments on commit 9730dde

Please sign in to comment.