Code editor additional languages #2684
Conversation
hashibot-hds
added
packages/components
docs-website
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| Ruby = 'ruby', | ||
| Shell = 'shell', | ||
| Go = 'go', | ||
| Hcl = 'hcl', | ||
| Javascript = 'javascript', |
There was a problem hiding this comment.
Nit: should it be JavaScript?
| "@hashicorp/design-system-components": minor | ||
| --- | ||
|
|
||
| hds-code-editor: Add language syntax highlighting suport for JavaScript and Rego |
There was a problem hiding this comment.
Nit: should we include that theres a new dep @codemirror/lang-javascript?
| console.log(message); | ||
| } | ||
|
|
||
| sayMessage(); | ||
| }`, |
There was a problem hiding this comment.
[nit] This is causing a trailing bracket in the showcase example.
| "@hashicorp/design-system-components": minor | ||
| --- | ||
|
|
||
| hds-code-editor: Add language syntax highlighting suport for JavaScript and Rego |
There was a problem hiding this comment.
| hds-code-editor: Add language syntax highlighting suport for JavaScript and Rego | |
| `hds-code-editor` modifier - Add language syntax highlighting suport for JavaScript and Rego | |
| `CodeEditor` - Add language syntax highlighting suport for JavaScript and Rego |
[nit] Need to tweak format slightly, and add in a line for the CodeEditor so the parser generate a version history for it.
There was a problem hiding this comment.
There aren't any direct changes to the code editor component, just the modifier. Do you think we still need to tag the component with changes?
There was a problem hiding this comment.
There aren't any direct changes to the code editor component, just the modifier. Do you think we still need to tag the component with changes?
While your take is accurate, all instances using the modifier (in our case the CodeEditor component) are benefitting from this new feature, so surfacing it at the component level makes sense to me. While we offer both a component and a modifier, the latter is more of an escape hatch for bespoke implementations.
There was a problem hiding this comment.
Makes sense - Thanks for your clarification.
|
Design will have to add these to the CodeEditor ~ will open up a branch for this in Figma. |
📌 Summary
If merged, this PR adds syntax highlighting support for JavaScript and Rego to the
hds-code-editormodifier.🛠️ Detailed description
📸 Screenshots
🔗 External links
Jira tickets:
HDS-4452
HDS-4469
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.