Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nested object attributes with json annotations #30

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

brandonc
Copy link
Collaborator

Prior to release 1.4.0, nested object attributes could be annotated with json tags. To maintain compatibility, this change adds a detection during marshaling to check for the presence of jsonapi annotations before trying recursively marshal those nested objects.

Prior to release 1.4.0, nested object attributes
could be annotated with `json` tags. To maintain
compatibility, this change adds a detection during
marshaling to check for the presence of `jsonapi`
annotations before trying recursively marshal
those nested objects.
@brandonc brandonc requested a review from a team as a code owner January 30, 2025 23:47
Copy link

@mukeshjc mukeshjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandonc brandonc merged commit fae13ce into main Jan 31, 2025
5 checks passed
@brandonc brandonc deleted the brandonc/handle_json_annotation_marshaling branch January 31, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants