Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update crypto library and update testing resources off removed Windows 2012 DC image. #457

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

JenGoldstrich
Copy link
Contributor

  • Update golang.org/x/crypto v0.31.0
  • Update version of Terraform Azure Provider used in CI
  • Update examples, and acceptance testing templates that try and use now removed Windows 2012 Datacenter image sku

@JenGoldstrich JenGoldstrich requested a review from a team as a code owner December 20, 2024 00:31
@@ -16,5 +16,4 @@ provider "azurerm" {
prevent_deletion_if_contains_resources = false
}
}
skip_provider_registration = true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been deprecated, and I don't remember us needing this.

…been removed, also update Terraform Azure provider version, I was seeing a bug on storage accounts, but upgrading this seems to fix it, the bugt was it having conflicts always during creation/deletion
Copy link

@galapas1 galapas1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JenGoldstrich JenGoldstrich merged commit e4d920b into main Dec 20, 2024
12 checks passed
@JenGoldstrich JenGoldstrich deleted the update_azure_deps branch December 20, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants