Added the possibility for VNET to be in another subscription #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
when will this be reviewed? |
JenGoldstrich
requested changes
Feb 19, 2025
| @@ -0,0 +1,1268 @@ | |||
| ÔÇó only configurations files on version: 2 are supported, yours is version: 0 , please update your configuration | |||
There was a problem hiding this comment.
Please remove this file from the diff
| @@ -3,6 +3,7 @@ | |||
|
|
|||
| # This is an example goreleaser.yaml file with some defaults. | |||
| # Make sure to check the documentation at http://goreleaser.com | |||
| version: 2 | |||
There was a problem hiding this comment.
Why did you include the version bump here? I assume that the License addition also is required by goreleaser v2? Either way we generally don't expect contributors to modify our goreleaser process, can you exclude this change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added functionality to enable the use of VNets from a different subscription. This allows VMs to connect to VNets in an external subscription, addressing specific cross-subscription networking needs.
Context
While creating build server images, sysprep would fail in a subscription under Azure Defender for Cloud due to the automatic installation of agents. To resolve this issue, we moved the image creation process to a subscription without Azure Defender for Cloud.
However, due to strict network management policies, we needed to continue using an existing VNet in the original subscription.
Changes Made
Impact