[WIP] Openstack glance support #4283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- github.com/rackspace/gophercloud is now feature frozen and is replaced by the repo at github.com/gophercloud/gophercloud - Remove old vendored files for rackspace version of gophercloud - Add new vendored version of gophercloud from new repo - Fix various API changes in gophercloud - Remove support for RackSpace API keys (not supported in new gophercloud repo)
|
tested visibility works |
|
okay was able to test and both features work |
|
Will keep an eye out for tickets about removing the api_key field. If it becomes a problem we can either switch back to rackspace/gophercloud. Even though I think that library would work for us and preserve b/c, I decided to move to the new gophercloud/gophercloud because it's being supported, and terraform moved to it without much problem hashicorp/terraform#9407 |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4113
replaces #4211
b/c changes: removes rackspace API Key field
Haven't tested, but will now. If @clstokes or @rickard-von-essen want to take a look
TODO