importer-msgraph-metadata: fix bug that generated constant fields wit…

…hout first checking for array
hashicorp · Aug 14, 2024 · 7f663b6 · 7f663b6
1 parent c3a1f02
commit 7f663b6
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/tools/importer-msgraph-metadata/components/parser/types.go b/tools/importer-msgraph-metadata/components/parser/types.go
@@ -171,14 +171,6 @@ type ModelField struct {
 }
 
 func (f ModelField) DataApiSdkObjectDefinition(models Models) (*sdkModels.SDKObjectDefinition, error) {
-	if f.ConstantName != nil {
-		return &sdkModels.SDKObjectDefinition{
-			Nullable:      f.Nullable,
-			ReferenceName: f.ConstantName,
-			Type:          sdkModels.ReferenceSDKObjectDefinitionType,
-		}, nil
-	}
-
 	if f.Type == nil {
 		return nil, fmt.Errorf("field %q has no Type", f.Title)
 	}
@@ -251,6 +243,14 @@ func (f ModelField) DataApiSdkObjectDefinition(models Models) (*sdkModels.SDKObj
 		return nil, nil
 	}
 
+	if f.ConstantName != nil {
+		return &sdkModels.SDKObjectDefinition{
+			Nullable:      f.Nullable,
+			ReferenceName: f.ConstantName,
+			Type:          sdkModels.ReferenceSDKObjectDefinitionType,
+		}, nil
+	}
+
 	return &sdkModels.SDKObjectDefinition{
 		Nullable: f.Nullable,
 		Type:     f.Type.DataApiSdkObjectDefinitionType(),