Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools/data-api-differ: supporting for diffing Common Types #4225

Merged
merged 7 commits into from
Jun 27, 2024
Merged

tools/data-api-differ: supporting for diffing Common Types #4225

merged 7 commits into from
Jun 27, 2024

Conversation

tombuildsstuff
Copy link
Contributor

Fixes #4219

@tombuildsstuff
Copy link
Contributor Author

Looks good locally:

2024/06/21 14:58:07 ## Summary of Changes

* 👍 No Breaking Changes were detected.
* 👀 1 Non-Breaking Changes were detected.

---


## Non-Breaking Changes

**1 Non-Breaking Changes** were detected:

* ✅ **New CommonTypes API Version:** `v1`.

and

2024/06/21 14:58:33 ## Summary of Changes

* 🛑 **1 Breaking Changes** were detected.
* 👍 No Non-Breaking Changes were detected.

---


## Breaking Changes

**1 Breaking Changes** were detected:

* ❌ **Removed CommonTypes API Version:** `v1`.
* ```

@tombuildsstuff tombuildsstuff marked this pull request as ready for review June 21, 2024 12:59
Base automatically changed from refactor/data-api-to-use-repository to main June 21, 2024 13:15
@tombuildsstuff tombuildsstuff force-pushed the f/data-api-differ-common-types branch from 64cd477 to 3df9cc1 Compare June 24, 2024 10:30
@github-actions GitHub Actions
Copy link

Breaking Changes

No Breaking Changes were found 👍

@github-actions GitHub Actions
Copy link

Summary of Changes

No Breaking or Non-Breaking Changes were found 👍

@github-actions GitHub Actions
Copy link

New Resource ID Segments containing Static Identifiers

No new Resource ID Segments containing Static Identifiers were identified in the set of changes 🤙.

manicminer
manicminer approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tombuildsstuff, a few minor notes but otherwise LGTM 👍

tools/data-api-differ/internal/differ/differ_common_types.go Outdated Show resolved Hide resolved
tools/data-api-differ/internal/differ/differ.go Outdated Show resolved Hide resolved
tools/data-api-differ/internal/differ/differ_common_types_constants.go Show resolved Hide resolved
tools/data-api-differ/internal/differ/differ_common_types_constants.go Outdated Show resolved Hide resolved
tools/data-api-differ/internal/differ/differ_common_types_models.go Show resolved Hide resolved
tools/data-api-differ/internal/views/markdown.go Outdated Show resolved Hide resolved
tombuildsstuff and others added 7 commits June 27, 2024 14:32
@tombuildsstuff
tools/data-api-differ: support for detecting changes to Common Types
b3ddaa5 
Fixes #4219
@tombuildsstuff @manicminer
Update tools/data-api-differ/internal/differ/differ_common_types.go
1a1d55d 
Co-authored-by: Tom Bamford <[email protected]>
@tombuildsstuff @manicminer
Update tools/data-api-differ/internal/views/markdown.go
2bbb92b 
Co-authored-by: Tom Bamford <[email protected]>
@tombuildsstuff @manicminer
Update tools/data-api-differ/internal/differ/differ_common_types_cons…
fccdb6f 
…tants.go

Co-authored-by: Tom Bamford <[email protected]>
@tombuildsstuff @manicminer
Update tools/data-api-differ/internal/differ/differ_common_types_cons…
a070e29 
…tants.go

Co-authored-by: Tom Bamford <[email protected]>
@tombuildsstuff @manicminer
Update tools/data-api-differ/internal/differ/differ.go
50e01f6 
Co-authored-by: Tom Bamford <[email protected]>
@tombuildsstuff
tools/importer-rest-api-specs: fixing the build
bf59450
@tombuildsstuff tombuildsstuff force-pushed the f/data-api-differ-common-types branch from ba73c2e to bf59450 Compare June 27, 2024 12:32
@github-actions GitHub Actions
Copy link

Breaking Changes

No Breaking Changes were found 👍

@github-actions GitHub Actions
Copy link

Summary of Changes

No Breaking or Non-Breaking Changes were found 👍

@github-actions GitHub Actions
Copy link

New Resource ID Segments containing Static Identifiers

No new Resource ID Segments containing Static Identifiers were identified in the set of changes 🤙.

@tombuildsstuff tombuildsstuff merged commit 99491e8 into main Jun 27, 2024
3 checks passed
@tombuildsstuff tombuildsstuff deleted the f/data-api-differ-common-types branch June 27, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manicminer manicminer manicminer approved these changes

Assignees
No one assigned
Labels
tools/data-api-differ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tools/data-api-differ: support for detecting changes to Common Types
2 participants
@tombuildsstuff @manicminer