Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows special characters for db password #325

Closed
wants to merge 9 commits into from
Closed

Conversation

theoskolnik
Copy link

Background

Adds support for specified special characters in db password.

@theoskolnik theoskolnik requested a review from a team as a code owner March 27, 2024 20:17
nikolasrieble
nikolasrieble previously approved these changes Mar 28, 2024
Copy link
Contributor

@nikolasrieble nikolasrieble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I only have a minor non blocking question. 🚀

length = 128
special = true
min_special = 4
override_special = "+(!]&;$)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Could you please share the reason behind these specific characters for override_special? This looks like a learning opportunity to me.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The override_special setting indicates exactly which special characters to include in the random string that is generated (for example, there is no "@" symbol and so that special char will not be included in the output string).

@theoskolnik
Copy link
Author

Closing for now.

@theoskolnik theoskolnik closed this Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants