Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update deprecated default M4 type to M5 #328

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

nikolasrieble
Copy link
Contributor

@nikolasrieble nikolasrieble commented Apr 22, 2024

Background

On the 29th of March, AWS has disabled new creation of M4 type instances of RDS. Instead, the recommendation to use M5 type instances.
https://repost.aws/articles/AR_Rw2Xbe5Q9O1ZPKbU5S4Mg/amazon-rds-for-sql-server-is-ending-support-for-m4-r4-and-t2-database-instances-on-march-29-2024

In this PR we update the db size default value.

How has this been tested

I did not test it directly, but instead, verified that there are no orderable options for "db.m4.xlarge"

aws rds describe-orderable-db-instance-options \
    --region "us-west-2" \
    --db-instance-class "db.m4.xlarge" \
    --engine postgres

and that on the other hand, there are plenty options with "db.m5.xlarge", including the current default version 12.15.

aws rds describe-orderable-db-instance-options \
    --region "us-west-2" \
    --db-instance-class "db.m5.xlarge" \
    --engine postgres

@nikolasrieble nikolasrieble requested a review from a team as a code owner April 22, 2024 09:27
@nikolasrieble nikolasrieble merged commit 8142d5f into main Apr 22, 2024
4 checks passed
@nikolasrieble nikolasrieble deleted the chore.upgradeDefaultVersionOfPostgres branch April 22, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants