Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amazon RDS deployment strategy #341

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Conversation

harshit410
Copy link
Contributor

Background

This PR enables the dynamic setup of Amazon RDS deployment strategies. Previously, the only option was to deploy RDS instances using a Multi-AZ configuration, which, while providing high availability, is costly and can increase release test runtimes.
Some release tests may not require such a high level of availability and can work with the Single-AZ Configuration. Therefore, the ability to dynamically configure deployment strategies offers a more flexible and efficient approach.
This PR also allows for the dynamic setup of the allow_major_version_upgrade variable, further enhancing customization and optimization.

Relates to

Postgres Compatibility release test = https://hashicorp.atlassian.net/browse/TF-16228

How Has This Been Tested

The changes do not introduce significant modifications. Care has been taken to ensure that existing release tests are not disrupted by running the following GHA run -:

made ci-aws-fdo-docker-active-active-feature and GHA run
https://github.com/hashicorp/terraform-enterprise/actions/runs/12256134039/job/34190732349

@harshit410 harshit410 requested a review from a team as a code owner December 10, 2024 12:49
Copy link

hashicorp-cla-app bot commented Dec 10, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@nikolasrieble nikolasrieble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea! Lets please take double caution and add the default values in both places

modules/database/variables.tf Show resolved Hide resolved
@nikolasrieble nikolasrieble self-requested a review December 10, 2024 13:23
@harshit410 harshit410 merged commit 7fb831d into main Dec 10, 2024
3 checks passed
@harshit410 harshit410 deleted the harshit410/postgres_compatibility branch December 10, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants