[TF-23439] Removing PostgreSQL Minor Version in AWS Release tests #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG:
no-impact
Background
This PR removes the dependency on the minor version of PostgreSQL and only specifies the major version for the release tests. This change allows AWS RDS to automatically utilize the latest available minor version for the specified major version at the time of creation.
Summary
Currently, some of the release tests associated with the AWS Environment have the minor version of the PostgreSQL Engine hardcoded. Some AWS Release tests have failed due to Amazon RDS discontinuing support for the specific minor version of PostgreSQL. One of the incidents encountered in the following run : https://github.com/hashicorp/terraform-enterprise/actions/runs/12774604392/job/35657266311 where the error was:
Error: creating RDS DB Instance (up-coral-tfe20250113001829240000000001): operation error RDS: CreateDBInstance, https response error StatusCode: 400, RequestID: a10524b7-3a93-40bd-8813-95bbedd620b5, api error InvalidParameterCombination: Cannot find version 16.2 for postgresDoes this PR make a substantial change to TFE's architecture?
NO, it's a tests only PR.
How Has This Been Tested
docker_active_active_featuremodule of the terraform-enterprise/release/internal/spec/terraform/modules/fdo/aws/docker_active_active_feature/ repository to use this branch (as docker_active_active_feature module is using this repository directly )make
ci-aws-fdo-docker-active-active-featureand GHA runGithub Run = https://github.com/hashicorp/terraform-enterprise/actions/runs/12884720233