Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TF-15070] Rename production_type to operational_mode, and make active-active simple #250

Merged
merged 5 commits into from
May 31, 2024

Conversation

miguelhrocha
Copy link
Contributor

Background

Follow up from my previous PR #249. It removes all the complicated logic around active-active and renames the property to operational_mode to be consistent with Google and AWS modules.

@miguelhrocha miguelhrocha requested a review from a team as a code owner May 31, 2024 11:33
Miguel Hernández added 2 commits May 31, 2024 15:19
@miguelhrocha miguelhrocha merged commit 32addd0 into main May 31, 2024
3 checks passed
@miguelhrocha miguelhrocha deleted the TF-15070-fix-active-active-settings branch May 31, 2024 13:44
miguelhrocha pushed a commit that referenced this pull request Jun 7, 2024
…al_mode (#251)

The #250 introduced a breaking change for the variables of the root module; production_type now was called operational_mode. I didn't update the tests and examples at that time, this one addresses that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants