Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TF-11115, TF-11117, TF-11116] Adding object store connection string to output. #257

Merged
merged 1 commit into from
Dec 10, 2024
Merged

TF-11115, TF-11117, TF-11116] Adding object store connection string to output. #257

merged 1 commit into from
Dec 10, 2024

Conversation

kkavish
Copy link
Contributor

@kkavish kkavish commented Dec 9, 2024 •
edited
Loading

Background

  • Adding object store connection string to output so that release tests in TFE can pick this up and integrate with object store.

@kkavish kkavish marked this pull request as ready for review December 9, 2024 16:09
@kkavish kkavish requested a review from a team as a code owner December 9, 2024 16:09
@nikolasrieble
Copy link
Contributor

Why does the title link to three tickets? TF-11115, TF-11117, TF-11116?
Can you please add the ticket itself to the summary?

@kkavish
Copy link
Contributor Author

kkavish commented Dec 10, 2024

Why does the title link to three tickets? TF-11115, TF-11117, TF-11116? Can you please add the ticket itself to the summary?

This is actually to enable writing tests for those tickets.
Jira TF-11115
Jira TF-11116
Jira TF-11117

@kkavish kkavish merged commit 5d6c1aa into main Dec 10, 2024
4 checks passed
@kkavish kkavish deleted the kkavish/object-store-integration branch December 10, 2024 11:07
@kkavish
Copy link
Contributor Author

kkavish commented Dec 10, 2024

Why does the title link to three tickets? TF-11115, TF-11117, TF-11116? Can you please add the ticket itself to the summary?

While going through the code I saw this pattern being followed, so for consistency changed it to avoid mentioning index [0].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikolasrieble nikolasrieble nikolasrieble approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kkavish @nikolasrieble