Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the sensitive and the environmentVariable properties optional #132

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jtyr
Copy link
Contributor

@jtyr jtyr commented Apr 11, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

This PR is makes the sensitive and the environmentVariable properties of the spec.variables optional. This allows to write less cluttered YAML as the values are by default false and the property must be present only if the user wants to set it to true. This PR needs to be rebased once the PR #129 is merged to remove most of the changes in the CRD.

Manifest without this PR:

...
spec:
  variables:
    - key: key1
      value: null value 1
      sensitive: false
      environmentVariable: false
    - key: key2
      sensitive: true
      sensitive: false
      environmentVariable: false

Manifest with this PR:

...
spec:
  variables:
    - key: key1
      value: null value 1
    - key: key2
      sensitive: true

Release note for CHANGELOG:

The sensitive and the environmentVariable properties of spec.variables are optional

@jtyr
Copy link
Contributor Author

jtyr commented Jul 5, 2022

This PR is rebased now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant