Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for output annotations #134

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jtyr
Copy link
Contributor

@jtyr jtyr commented Apr 12, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

This PR is adding the ability to define Annotations on the output Secret generated by the operator. This allows to consume the secret by other tools like kubernetes-reflector. This PR needs to be rebased once the PR #129 is merged to remove most of the changes in the CRD.

The Workspace can contain spec.outputAnnotations:

...
spec:
  outputAnnotations:
    foo: bar
...

Such Annotations are then inserted into the final output Secret:

$ kubectl get secret test-outputs
...
metadata:
  annotations:
    foo: bar
...

Release note for CHANGELOG:

Added ability to specify annotations for the output secret

@jtyr
Copy link
Contributor Author

jtyr commented Jul 5, 2022

This PR is rebased now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant