Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature : add mediaconvert jobtemplate resource #38111

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

lazouz
Copy link

@lazouz lazouz commented Jun 25, 2024

Description

This Merge request aims to add mediaconvert jobtemplate resource to the AWS terrafom provider

This is a draft merge request for now

Relations

Relates #11189

References

Output from Acceptance Testing

yet to come

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. service/mediaconvert Issues and PRs that pertain to the mediaconvert service. generators Relates to code generators. labels Jun 25, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jun 25, 2024
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 25, 2024
@lazouz
Copy link
Author

lazouz commented Jul 22, 2024

Hello @justinretzolk, If by any chance you have 10 minutes for this PR, can you give me advice about :

  • testing this new resource the correct way
  • the code handling the http requests to AWS API, at the end of the file job_template.go
  • anything that you could find good or bad in this PR that can help to improve it (as I said somewhere else, I'm not a go developer, but I'll be glad to make progress )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generators Relates to code generators. new-resource Introduces a new resource. service/mediaconvert Issues and PRs that pertain to the mediaconvert service. size/XL Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants