Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/ssm_parameter: add `value_wo' write-only attribute #40952

Merged
merged 34 commits into from
Feb 11, 2025
Merged

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Jan 15, 2025

Description

adding new write-only attribute value_wo

Relations

References

Depends on #41255

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccSSMParameter_' PKG=ssm

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/ssm/... -v -count 1 -parallel 20  -run=TestAccSSMParameter_ -timeout 360m -vet=off
2025/01/15 13:05:59 Initializing Terraform AWS Provider...
--- PASS: TestAccSSMParameter_DataType_ssmIntegration (44.26s)
--- PASS: TestAccSSMParameter_importByARN (44.40s)
--- PASS: TestAccSSMParameter_DataType_ec2Image (44.61s)
--- PASS: TestAccSSMParameter_Secure_key (44.78s)
--- PASS: TestAccSSMParameter_tags_DefaultTags_emptyResourceTag (48.25s)
--- PASS: TestAccSSMParameter_tags_DefaultTags_emptyProviderOnlyTag (48.44s)
--- PASS: TestAccSSMParameter_tags_EmptyMap (62.49s)
--- PASS: TestAccSSMParameter_Overwrite_updateDescription (66.48s)
--- PASS: TestAccSSMParameter_updateType (66.51s)
--- PASS: TestAccSSMParameter_Secure_keyUpdate (72.41s)
--- PASS: TestAccSSMParameter_Overwrite_updateToTags (76.75s)
--- PASS: TestAccSSMParameter_tags_DefaultTags_updateToResourceOnly (76.94s)
--- PASS: TestAccSSMParameter_DataType_update (77.41s)
--- PASS: TestAccSSMParameter_tags_AddOnUpdate (81.40s)
--- PASS: TestAccSSMParameter_tags_DefaultTags_updateToProviderOnly (85.06s)
--- PASS: TestAccSSMParameter_Secure_basic (43.94s)
--- PASS: TestAccSSMParameter_tags_EmptyTag_OnCreate (90.99s)
--- PASS: TestAccSSMParameter_Secure_insecureChangeSecure (91.79s)
--- PASS: TestAccSSMParameter_Overwrite_noOverwriteTags (49.78s)
--- PASS: TestAccSSMParameter_fullPath (46.57s)
--- PASS: TestAccSSMParameter_tier (99.94s)
--- PASS: TestAccSSMParameter_Overwrite_removeAttribute (67.70s)
--- PASS: TestAccSSMParameter_multiple (37.10s)
--- PASS: TestAccSSMParameter_changeNameForcesNew (74.18s)
--- PASS: TestAccSSMParameter_disappears (35.36s)
--- PASS: TestAccSSMParameter_Secure_insecure (91.03s)
--- PASS: TestAccSSMParameter_Tier_intelligentTieringOnUpdate (60.79s)
--- PASS: TestAccSSMParameter_basic (52.80s)
--- PASS: TestAccSSMParameter_tags_ComputedTag_OnCreate (51.45s)
--- PASS: TestAccSSMParameter_tags_EmptyTag_OnUpdate_Replace (87.23s)
--- PASS: TestAccSSMParameter_Overwrite_tags (50.16s)
--- PASS: TestAccSSMParameter_updateDescription (82.43s)
--- PASS: TestAccSSMParameter_updateValue (79.80s)
--- PASS: TestAccSSMParameter_tags_null (62.52s)
--- PASS: TestAccSSMParameter_Tier_intelligentTieringOnCreation (42.55s)
--- PASS: TestAccSSMParameter_tags (168.17s)
--- PASS: TestAccSSMParameter_tags_DefaultTags_nullNonOverlappingResourceTag (45.86s)
--- PASS: TestAccSSMParameter_tags_IgnoreTags_Overlap_DefaultTag (104.85s)
--- PASS: TestAccSSMParameter_tags_ComputedTag_OnUpdate_Replace (77.50s)
--- PASS: TestAccSSMParameter_Overwrite_basic (92.11s)
--- PASS: TestAccSSMParameter_tags_DefaultTags_providerOnly (173.60s)
--- PASS: TestAccSSMParameter_tags_DefaultTags_nullOverlappingResourceTag (39.56s)
--- PASS: TestAccSSMParameter_tags_EmptyTag_OnUpdate_Add (112.50s)
--- PASS: TestAccSSMParameter_tags_ComputedTag_OnUpdate_Add (68.84s)
--- PASS: TestAccSSMParameter_tags_IgnoreTags_Overlap_ResourceTag (96.02s)
--- PASS: TestAccSSMParameter_Tier_intelligentTieringToAdvanced (75.37s)
--- PASS: TestAccSSMParameter_Overwrite_cascade (42.05s)
--- PASS: TestAccSSMParameter_Tier_intelligentTieringToStandard (57.66s)
--- PASS: TestAccSSMParameter_tags_DefaultTags_nonOverlapping (68.69s)
--- PASS: TestAccSSMParameter_tags_DefaultTags_overlapping (66.22s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ssm	216.056s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ssm Issues and PRs that pertain to the ssm service. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Jan 15, 2025
@johnsonaj johnsonaj added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 15, 2025
@johnsonaj johnsonaj marked this pull request as ready for review February 5, 2025 19:06
@johnsonaj johnsonaj requested a review from a team as a code owner February 5, 2025 19:06
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. flex Pertains to FLatteners and EXpanders. labels Feb 5, 2025
jar-b
jar-b previously approved these changes Feb 10, 2025
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=ssm TESTS=TestAccSSMParameter_writeOnly
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/ssm/... -v -count 1 -parallel 20 -run='TestAccSSMParameter_writeOnly'  -timeout 360m -vet=off
2025/02/10 10:07:41 Initializing Terraform AWS Provider...
=== RUN   TestAccSSMParameter_writeOnly
=== PAUSE TestAccSSMParameter_writeOnly
=== CONT  TestAccSSMParameter_writeOnly
--- PASS: TestAccSSMParameter_writeOnly (21.09s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ssm        27.703s

Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@johnsonaj johnsonaj merged commit 1aaed0d into main Feb 11, 2025
44 checks passed
@johnsonaj johnsonaj deleted the ephemeral_write_only branch February 11, 2025 16:20
@github-actions github-actions bot added this to the v5.87.0 milestone Feb 11, 2025
terraform-aws-provider bot pushed a commit that referenced this pull request Feb 11, 2025
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 14, 2025
Copy link

This functionality has been released in v5.87.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

abicky added a commit to abicky/terraform-provider-azurerm that referenced this pull request Feb 16, 2025
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. flex Pertains to FLatteners and EXpanders. generators Relates to code generators. service/ssm Issues and PRs that pertain to the ssm service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants