Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support secondary email in aws_connect_user resource #41001

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

wpessers
Copy link

Description

Adds aws_connect_user resource support for the secondary_email option.

Relations

Closes #40931

Output from Acceptance Testing

% make testacc TESTS=TestAccConnect_serial/User PKG=connect
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/connect/... -v -count 1 -parallel 20 -run='TestAccConnect_serial/User'  -timeout 360m -vet=off
2025/01/19 20:23:15 Initializing Terraform AWS Provider...
=== RUN   TestAccConnect_serial
=== PAUSE TestAccConnect_serial
=== CONT  TestAccConnect_serial
=== RUN   TestAccConnect_serial/UserHierarchyGroup
=== RUN   TestAccConnect_serial/UserHierarchyGroup/basic
=== RUN   TestAccConnect_serial/UserHierarchyGroup/disappears
=== RUN   TestAccConnect_serial/UserHierarchyGroup/updateTags
=== RUN   TestAccConnect_serial/UserHierarchyGroup/parentGroupId
=== RUN   TestAccConnect_serial/UserHierarchyGroup/dataSource_id
=== RUN   TestAccConnect_serial/UserHierarchyGroup/dataSource_name
=== RUN   TestAccConnect_serial/UserHierarchyStructure
=== RUN   TestAccConnect_serial/UserHierarchyStructure/disappears
=== RUN   TestAccConnect_serial/UserHierarchyStructure/dataSource_id
=== RUN   TestAccConnect_serial/UserHierarchyStructure/basic
=== RUN   TestAccConnect_serial/User
=== RUN   TestAccConnect_serial/User/disappears
=== RUN   TestAccConnect_serial/User/phoneConfig
=== RUN   TestAccConnect_serial/User/routingProfileId
=== RUN   TestAccConnect_serial/User/securityProfileIds
=== RUN   TestAccConnect_serial/User/basic
=== RUN   TestAccConnect_serial/User/tags
=== RUN   TestAccConnect_serial/User/hierarchyGroupId
=== RUN   TestAccConnect_serial/User/identityInfo
=== RUN   TestAccConnect_serial/User/dataSource_id
=== RUN   TestAccConnect_serial/User/dataSource_name
--- PASS: TestAccConnect_serial (1676.77s)
    --- PASS: TestAccConnect_serial/UserHierarchyGroup (507.93s)
        --- PASS: TestAccConnect_serial/UserHierarchyGroup/basic (104.03s)
        --- PASS: TestAccConnect_serial/UserHierarchyGroup/disappears (75.24s)
        --- PASS: TestAccConnect_serial/UserHierarchyGroup/updateTags (90.91s)
        --- PASS: TestAccConnect_serial/UserHierarchyGroup/parentGroupId (85.18s)
        --- PASS: TestAccConnect_serial/UserHierarchyGroup/dataSource_id (77.03s)
        --- PASS: TestAccConnect_serial/UserHierarchyGroup/dataSource_name (75.54s)
    --- PASS: TestAccConnect_serial/UserHierarchyStructure (267.52s)
        --- PASS: TestAccConnect_serial/UserHierarchyStructure/disappears (74.77s)
        --- PASS: TestAccConnect_serial/UserHierarchyStructure/dataSource_id (74.30s)
        --- PASS: TestAccConnect_serial/UserHierarchyStructure/basic (118.45s)
    --- PASS: TestAccConnect_serial/User (901.31s)
        --- PASS: TestAccConnect_serial/User/disappears (98.65s)
        --- PASS: TestAccConnect_serial/User/phoneConfig (98.80s)
        --- PASS: TestAccConnect_serial/User/routingProfileId (92.79s)
        --- PASS: TestAccConnect_serial/User/securityProfileIds (100.81s)
        --- PASS: TestAccConnect_serial/User/basic (78.11s)
        --- PASS: TestAccConnect_serial/User/tags (98.32s)
        --- PASS: TestAccConnect_serial/User/hierarchyGroupId (88.98s)
        --- PASS: TestAccConnect_serial/User/identityInfo (88.70s)
        --- PASS: TestAccConnect_serial/User/dataSource_id (77.87s)
        --- PASS: TestAccConnect_serial/User/dataSource_name (78.28s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/connect    1676.861s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/connect Issues and PRs that pertain to the connect service. needs-triage Waiting for first response or review from a maintainer. labels Jan 19, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @wpessers 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@wpessers wpessers marked this pull request as ready for review January 19, 2025 21:18
@wpessers wpessers requested a review from a team as a code owner January 19, 2025 21:18
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/connect Issues and PRs that pertain to the connect service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add support for secondary email in aws_connect_user identity info
2 participants