Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes appstream test errors #41341

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Fixes appstream test errors #41341

merged 2 commits into from
Feb 11, 2025

Conversation

gdavison
Copy link
Contributor

Description

Fixes TestAccAppStreamStack_withTags

Fixes TestAccAppStreamFleet_multiSession

Output from Acceptance Testing

% make testacc PKG=appstream TESTS='TestAccAppStreamStack_withTags|TestAccAppStreamFleet_multiSession'

--- PASS: TestAccAppStreamStack_withTags (38.95s)
--- PASS: TestAccAppStreamFleet_multiSession (779.75s)

@gdavison gdavison requested a review from a team as a code owner February 11, 2025 19:20
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/appstream Issues and PRs that pertain to the appstream service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Feb 11, 2025
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@gdavison gdavison merged commit 71a0486 into main Feb 11, 2025
43 checks passed
@gdavison gdavison deleted the t-appstream-stack-tags branch February 11, 2025 20:55
@github-actions github-actions bot added this to the v5.87.0 milestone Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/appstream Issues and PRs that pertain to the appstream service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants