Skip to content

Conversation

@sharp-pixel
Copy link

@sharp-pixel sharp-pixel commented Oct 26, 2025

  • Add checkAndReturnChangeProgressError to detect validation failures and cancellations
  • Add getChangeProgressError to fetch detailed error information from DescribeDomainChangeProgress API
  • Integrate error checks into waitForDomainCreation, waitForDomainUpdate, and waitForDomainDelete
  • Replace deprecated tfresource.NotFound with retry.NotFound

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

This PR adds additional state validation.
When a change validation check failed, it previously wasn't caught and would result in an infinite wait, while the OpenSearch Domain creation would have failed in the control plane.

Examples of such events are:

  • Dedicated master node types not compatible with the cluster nodes and size.
  • Insufficient capacity

Relations

Closes #0000

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

- Add checkAndReturnChangeProgressError to detect validation failures and cancellations
- Add getChangeProgressError to fetch detailed error information from DescribeDomainChangeProgress API
- Integrate error checks into waitForDomainCreation, waitForDomainUpdate, and waitForDomainDelete
- Replace deprecated tfresource.NotFound with retry.NotFound
@sharp-pixel sharp-pixel requested a review from a team as a code owner October 26, 2025 17:43
@github-actions
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions
Copy link
Contributor

⚠️ Our automation has detected the following potential issues with your pull request


❌ Changelog Entry Required (Click to expand)

The proposed change requires a changelog entry. Please see the Changelog Process section of the contributing guide for information on the changelog generation process.

Tip: This check is not triggered for draft pull requests, since the pull request number is not known until the pull request is opened and is required to create a changelog entry. Opening a pull request first as a draft, adding the requisite changelog entry file, and then marking the pull request as ready for review will prevent future warnings.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/opensearch Issues and PRs that pertain to the opensearch service. size/S Managed by automation to categorize the size of a PR. labels Oct 26, 2025
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Requests to existing resources that expand the functionality or scope. service/opensearch Issues and PRs that pertain to the opensearch service. size/S Managed by automation to categorize the size of a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants