Skip to content

[New Resource] - target_account_configuration for FIS #44875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Nov 2, 2025
Merged

[New Resource] - target_account_configuration for FIS #44875

merged 10 commits into from
Nov 2, 2025

Conversation

@subham-ibmhc
Copy link
Contributor

@subham-ibmhc subham-ibmhc commented Oct 30, 2025 •
edited by johnsonaj
Loading

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Adds a new resource target_account_configuration to AWS FIS.

Relations

Closes #44870
Closes #44884

References

https://docs.aws.amazon.com/fis/latest/APIReference/API_CreateTargetAccountConfiguration.html
https://docs.aws.amazon.com/fis/latest/APIReference/API_ListTargetAccountConfigurations.html
https://docs.aws.amazon.com/fis/latest/APIReference/API_UpdateTargetAccountConfiguration.html
https://docs.aws.amazon.com/fis/latest/APIReference/API_DeleteTargetAccountConfiguration.html

Output from Acceptance Testing

% make testacc TESTS=TestAccFISTargetAccountConfiguration_ PKG=fis                                                               
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 r/aws_target_account_configuration-New-Resource 🌿...
TF_ACC=1 go1.24.8 test ./internal/service/fis/... -v -count 1 -parallel 20 -run='TestAccFISTargetAccountConfiguration_'  -timeout 360m -vet=off
2025/10/30 11:48:29 Creating Terraform AWS Provider (SDKv2-style)...
2025/10/30 11:48:29 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccFISTargetAccountConfiguration_basic
=== PAUSE TestAccFISTargetAccountConfiguration_basic
=== RUN   TestAccFISTargetAccountConfiguration_update
=== PAUSE TestAccFISTargetAccountConfiguration_update
=== RUN   TestAccFISTargetAccountConfiguration_disappears
=== PAUSE TestAccFISTargetAccountConfiguration_disappears
=== CONT  TestAccFISTargetAccountConfiguration_basic
=== CONT  TestAccFISTargetAccountConfiguration_disappears
=== CONT  TestAccFISTargetAccountConfiguration_update
--- PASS: TestAccFISTargetAccountConfiguration_disappears (28.02s)
--- PASS: TestAccFISTargetAccountConfiguration_basic (31.41s)
--- PASS: TestAccFISTargetAccountConfiguration_update (49.47s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/fis        54.167s

...

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. sweeper Pertains to changes to or issues with the sweeper. generators Relates to code generators. service/fis Issues and PRs that pertain to the fis service. size/XL Managed by automation to categorize the size of a PR. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Oct 30, 2025
@subham-ibmhc subham-ibmhc added the rnd-ind-provider rnd-ind-provider label Oct 30, 2025
johnsonaj
johnsonaj reviewed Oct 30, 2025
View reviewed changes
johnsonaj
johnsonaj reviewed Oct 30, 2025
View reviewed changes
johnsonaj
johnsonaj reviewed Oct 30, 2025
View reviewed changes
johnsonaj
johnsonaj reviewed Oct 30, 2025
View reviewed changes
johnsonaj
johnsonaj reviewed Oct 30, 2025
View reviewed changes
@subham-ibmhc subham-ibmhc marked this pull request as ready for review October 30, 2025 19:49
@subham-ibmhc subham-ibmhc requested a review from a team as a code owner October 30, 2025 19:49
@RezaImany
Copy link

RezaImany commented Oct 30, 2025

Hey, I noticed this PR (#44875) seems based on my earlier contribution (#44870 ). I’m glad to see it’s moving forward! Could you please confirm attribution or link my PR for continuity?

johnsonaj
johnsonaj approved these changes Oct 30, 2025
View reviewed changes
Copy link
Member

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make testacc TESTS=TestAccFISTargetAccountConfiguration_ PKG=fis

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 r/aws_target_account_configuration-New-Resource 🌿...
TF_ACC=1 go1.24.8 test ./internal/service/fis/... -v -count 1 -parallel 20 -run='TestAccFISTargetAccountConfiguration_'  -timeout 360m -vet=off
2025/10/30 17:29:24 Creating Terraform AWS Provider (SDKv2-style)...
2025/10/30 17:29:24 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccFISTargetAccountConfiguration_basic
=== PAUSE TestAccFISTargetAccountConfiguration_basic
=== RUN   TestAccFISTargetAccountConfiguration_update
=== PAUSE TestAccFISTargetAccountConfiguration_update
=== RUN   TestAccFISTargetAccountConfiguration_disappears
=== PAUSE TestAccFISTargetAccountConfiguration_disappears
=== CONT  TestAccFISTargetAccountConfiguration_basic
=== CONT  TestAccFISTargetAccountConfiguration_disappears
=== CONT  TestAccFISTargetAccountConfiguration_update
--- PASS: TestAccFISTargetAccountConfiguration_disappears (16.53s)
--- PASS: TestAccFISTargetAccountConfiguration_basic (18.73s)
--- PASS: TestAccFISTargetAccountConfiguration_update (28.43s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fis	36.336s

@subham-ibmhc
Copy link
Contributor Author

subham-ibmhc commented Oct 31, 2025

Hey, I noticed this PR (#44875) seems based on my earlier contribution (#44870 ). I’m glad to see it’s moving forward! Could you please confirm attribution or link my PR for continuity?

Your PR will be linked to the parent issue and closed when the feature is merged.
Thank you for your contribution. 🚀

@subham-ibmhc subham-ibmhc merged commit b951efd into hashicorp:main Nov 2, 2025
44 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2025

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v6.20.0 milestone Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnsonaj johnsonaj johnsonaj approved these changes

Assignees

No one assigned

Labels

documentation Introduces or discusses updates to documentation. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. rnd-ind-provider rnd-ind-provider service/fis Issues and PRs that pertain to the fis service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Milestone

v6.20.0

Development

Successfully merging this pull request may close these issues.

[new resource] aws_fis_target_account_configuration

3 participants

@subham-ibmhc @RezaImany @johnsonaj