-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[Enhancement] Add config options to EKS Node Group node_repair_config
#44894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Add config options to EKS Node Group node_repair_config
#44894
Conversation
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this PR, @james0209
--- PASS: TestAccEKSNodeGroup_nodeRepairConfig_basic (1133.65s)
--- PASS: TestAccEKSNodeGroup_nodeRepairConfig_percentages (1217.76s)
--- PASS: TestAccEKSNodeGroup_nodeRepairConfig_overrides (1219.89s)
--- PASS: TestAccEKSNodeGroup_nodeRepairConfig_counts (1248.28s)
|
Warning This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them. Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed. |
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the library.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Description
Adds support for node auto repair configuration fields to the
aws_eks_node_groupresource'snode_repair_configblock.New fields added to
node_repair_config:max_parallel_nodes_repaired_count(Optional, Integer, min: 1) - Conflicts withmax_parallel_nodes_repaired_percentage.max_parallel_nodes_repaired_percentage(Optional, Integer, 1-100) - Conflicts withmax_parallel_nodes_repaired_count.max_unhealthy_node_threshold_count(Optional, Integer, min: 1) - Conflicts withmax_unhealthy_node_threshold_percentage.max_unhealthy_node_threshold_percentage(Optional, Integer, 1-100) - Conflicts withmax_unhealthy_node_threshold_count.node_repair_config_overrides(Optional, List) - Each override block requires:min_repair_wait_time_mins(Required, Integer, min: 1)node_monitoring_condition(Required, String)node_unhealthy_reason(Required, String)repair_action(Required, String, Valid Values: "Replace" | "Reboot" | "NoAction")Relations
Closes #44603
References
Output from Acceptance Testing
Snippets from describing the Nodepools created by the Acceptance Tests: