Skip to content

Conversation

@jackroberts-gh
Copy link
Contributor

@jackroberts-gh jackroberts-gh commented Dec 15, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

N/A

Description

Adds a new Service mpa as per instructions in docs.

Relations

Relates #43848 as a pre-requisite.

References

#43848

Output from Acceptance Testing

N/A

Other Notes

make gen made some updates seemingly unrelated to mpa - see commit (not all changes in that commit, but some)

@github-actions
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions
Copy link
Contributor

⚠️ Our automation has detected the following potential issues with your pull request


❌ Dependency Changes (Click to expand)

Typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. For more information, see the Dependency Updates section of the contributing guide.

Remove any changes to the go.mod or go.sum files and commit them into this pull request to prevent delays with reviewing and potentially merging it.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
  • Ensure the new AWS service changes are following the Adding a New AWS Service section of the contributing guide, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
  • If this pull request is already a separate pull request from the above item, you can ignore this message.
❌ Changelog Entry Required (Click to expand)

The proposed change requires a changelog entry. Please see the Changelog Process section of the contributing guide for information on the changelog generation process.

Tip: This check is not triggered for draft pull requests, since the pull request number is not known until the pull request is opened and is required to create a changelog entry. Opening a pull request first as a draft, adding the requisite changelog entry file, and then marking the pull request as ready for review will prevent future warnings.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. provider Pertains to the provider itself, rather than any interaction with AWS. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. generators Relates to code generators. github_actions Pull requests that update Github_actions code size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. linter Pertains to changes to or issues with the various linters. sweeper Pertains to changes to or issues with the sweeper. size/XL Managed by automation to categorize the size of a PR. labels Dec 15, 2025
@jackroberts-gh
Copy link
Contributor Author

jackroberts-gh commented Dec 15, 2025

❌ 🆗 Dependency Changes - I believe these are legitimate when adding a new service, following the "Adding a new service docs".

❌ 🆘 Changelog Entry Required - Not clear if a CHANGELOG file is needed for this type of change? Or whether it would only be needed for the resources that come later.

@justinretzolk justinretzolk added new-service Introduces a new service. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 16, 2025
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. client-connections Pertains to the AWS Client and service connections. labels Jan 9, 2026
@jackroberts-gh jackroberts-gh reopened this Jan 9, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@jackroberts-gh
Copy link
Contributor Author

go test seems to be failing because the test wants to use expected provider with region set to us-west-2, but the service is us-east-1 only, which I specified in names.

Unsure what to do in this case - I could do with some guidance! I can see that arcregionswitch is a similar service (us-east-1, not global) and it doesn't seem to have a _test.go file for it's service. However, I can't see how that is controlled or if that's the correct approach? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. github_actions Pull requests that update Github_actions code linter Pertains to changes to or issues with the various linters. new-service Introduces a new service. provider Pertains to the provider itself, rather than any interaction with AWS. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. size/L Managed by automation to categorize the size of a PR. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants