azurerm_windows_web_app - Set dotnet_version when CurrentStack is set to dotnetcore

[oWretch]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This PR resolves an issue where Terraform constantly creates diffs if the CurrentStack is set to dotnetcore and the version is set with the dotnet_version property. It also deprecates the dotnetcore_version property as it is no longer exposed as a separate stack type.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

terraform-provider-azurerm % make acctests SERVICE='appservice' TESTARGS='-run="TestAccWindowsWebApp_(basic|complete|withDotNet|updateAppStack)"' TESTTIMEOUT='60m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/appservice -run="TestAccWindowsWebApp_(basic|complete|withDotNet|updateAppStack)" -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccWindowsWebApp_basic
=== PAUSE TestAccWindowsWebApp_basic
=== RUN   TestAccWindowsWebApp_complete
=== PAUSE TestAccWindowsWebApp_complete
=== RUN   TestAccWindowsWebApp_completeUpdated
=== PAUSE TestAccWindowsWebApp_completeUpdated
=== RUN   TestAccWindowsWebApp_withDotNetCore
=== PAUSE TestAccWindowsWebApp_withDotNetCore
=== RUN   TestAccWindowsWebApp_withDotNet4
=== PAUSE TestAccWindowsWebApp_withDotNet4
=== RUN   TestAccWindowsWebApp_withDotNet5
=== PAUSE TestAccWindowsWebApp_withDotNet5
=== RUN   TestAccWindowsWebApp_withDotNet60
=== PAUSE TestAccWindowsWebApp_withDotNet60
=== RUN   TestAccWindowsWebApp_withDotNet70
=== PAUSE TestAccWindowsWebApp_withDotNet70
=== RUN   TestAccWindowsWebApp_withDotNet80
=== PAUSE TestAccWindowsWebApp_withDotNet80
=== RUN   TestAccWindowsWebApp_updateAppStack
=== PAUSE TestAccWindowsWebApp_updateAppStack
=== CONT  TestAccWindowsWebApp_basic
=== CONT  TestAccWindowsWebApp_withDotNet5
=== CONT  TestAccWindowsWebApp_withDotNetCore
=== CONT  TestAccWindowsWebApp_completeUpdated
=== CONT  TestAccWindowsWebApp_withDotNet4
=== CONT  TestAccWindowsWebApp_withDotNet80
=== CONT  TestAccWindowsWebApp_withDotNet70
=== CONT  TestAccWindowsWebApp_complete
=== CONT  TestAccWindowsWebApp_withDotNet60
=== CONT  TestAccWindowsWebApp_updateAppStack
--- PASS: TestAccWindowsWebApp_withDotNet80 (342.98s)
--- PASS: TestAccWindowsWebApp_withDotNet5 (344.90s)
--- PASS: TestAccWindowsWebApp_withDotNet4 (350.99s)
--- PASS: TestAccWindowsWebApp_withDotNet70 (354.36s)
--- PASS: TestAccWindowsWebApp_basic (372.63s)
--- PASS: TestAccWindowsWebApp_withDotNet60 (375.29s)
--- PASS: TestAccWindowsWebApp_withDotNetCore (395.82s)
--- PASS: TestAccWindowsWebApp_complete (449.29s)
--- PASS: TestAccWindowsWebApp_updateAppStack (757.57s)
--- PASS: TestAccWindowsWebApp_completeUpdated (1136.71s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/appservice    1139.199s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_windows_web_app - resolve constant diffs between dotnet_version and dotnetcore_version [azurerm_windows_web_app - Set dotnet_version when CurrentStack is set to dotnetcore #27255]
• azurerm_windows_web_app_slot - resolve constant diffs between dotnet_version and dotnetcore_version [azurerm_windows_web_app - Set dotnet_version when CurrentStack is set to dotnetcore #27255]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #22239
Fixes #24206

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[rcskosir]

Thank you so much for taking the time to put this together! We really appreciate your contribution.
Apologies for the delay in reviewing it. This service's current behavior requires some investigation, and we'll need to allocate some time to fully look into it. Rest assured, we'll review this as soon as we can.
Thanks again for your patience, and we'll keep you updated on the progress!