-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for new service stack: API Center #28007
base: main
Are you sure you want to change the base?
Conversation
This PR is being labeled as "stale" because it has not been updated for 30 or more days. If this PR is still valid, please remove the "stale" label. If this PR is blocked, please add it to the "Blocked" milestone. If you need some help completing this PR, please leave a comment letting us know. Thank you! |
@favoretti is this ready for review or could we close this until this is ready? |
@stephybun sorry, inbetween all the holidays and a lot of travel, I'm slowly working on that. Should be able to get the first set of resources out to be merged in the next couple of weeks. I have converted it to draft for now if you don't mind - I wanna keep the official checks running every so often to check my own sanity :) |
1ab8978
to
6240740
Compare
@stephybun Can we take a pass at these 2? I'll start a new PR for API and metadata support. Thanks! |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@favoretti I've looked through the environment resource, a lot of comments I left on that resource should be applied to the api center service resource. Could you please fix those up before I do another pass through?
internal/services/apicenter/apicenter_environment_resource_test.go
Outdated
Show resolved
Hide resolved
internal/services/apicenter/apicenter_environment_resource_test.go
Outdated
Show resolved
Hide resolved
internal/services/apicenter/apicenter_environment_resource_test.go
Outdated
Show resolved
Hide resolved
internal/services/apicenter/apicenter_environment_resource_test.go
Outdated
Show resolved
Hide resolved
internal/services/apicenter/apicenter_environment_resource_test.go
Outdated
Show resolved
Hide resolved
Thank you! I'll fix it up ASAP. |
7d37855
to
9fe0a99
Compare
Co-authored-by: stephybun <[email protected]>
Co-authored-by: stephybun <[email protected]>
Co-authored-by: stephybun <[email protected]>
|
Add support for Azure API Center
New resource:
azurerm_apicenter_service
New resource:
azurerm_apicenter_environment
Community Note
Description
PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_apicenter_service
[Support for new service stack: API Center #28007]azurerm_apicenter_environment
[Support for new service stack: API Center #28007]This is a (please select all that apply):
Note
If this PR changes meaningfully during the course of review please update the title and description as required.