Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for new service stack: API Center #28007

Open
wants to merge 33 commits into
base: main
Choose a base branch
from

Conversation

favoretti
Copy link
Contributor

@favoretti favoretti commented Nov 14, 2024

Add support for Azure API Center

New resource: azurerm_apicenter_service
New resource: azurerm_apicenter_environment

  • service
  • service docs
  • environment
  • environment docs

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@favoretti favoretti requested review from katbyte and a team as code owners November 14, 2024 00:32
@favoretti favoretti changed the title Support for new service stack: API Center WIP: Support for new service stack: API Center Nov 14, 2024
Copy link

This PR is being labeled as "stale" because it has not been updated for 30 or more days.

If this PR is still valid, please remove the "stale" label. If this PR is blocked, please add it to the "Blocked" milestone.

If you need some help completing this PR, please leave a comment letting us know. Thank you!

@github-actions github-actions bot added the stale label Dec 16, 2024
@stephybun
Copy link
Member

@favoretti is this ready for review or could we close this until this is ready?

@github-actions github-actions bot removed the stale label Jan 10, 2025
@favoretti favoretti marked this pull request as draft January 10, 2025 13:11
@favoretti
Copy link
Contributor Author

@stephybun sorry, inbetween all the holidays and a lot of travel, I'm slowly working on that. Should be able to get the first set of resources out to be merged in the next couple of weeks. I have converted it to draft for now if you don't mind - I wanna keep the official checks running every so often to check my own sanity :)

@favoretti favoretti force-pushed the favoretti/apicenter branch from 1ab8978 to 6240740 Compare January 22, 2025 13:07
@favoretti favoretti marked this pull request as ready for review January 22, 2025 15:15
@favoretti
Copy link
Contributor Author

@stephybun Can we take a pass at these 2? I'll start a new PR for API and metadata support. Thanks!

@favoretti favoretti changed the title WIP: Support for new service stack: API Center Support for new service stack: API Center Jan 22, 2025
@favoretti
Copy link
Contributor Author

$ TF_ACC=1 go test -v ./internal/services/apicenter -timeout=1000m
=== RUN   TestAccApicenterEnvironment_basic
=== PAUSE TestAccApicenterEnvironment_basic
=== RUN   TestAccApicenterEnvironment_complete
=== PAUSE TestAccApicenterEnvironment_complete
=== RUN   TestAccApicenterEnvironment_requiresImport
=== PAUSE TestAccApicenterEnvironment_requiresImport
=== RUN   TestAccApicenterService_basic
=== PAUSE TestAccApicenterService_basic
=== RUN   TestAccApicenterService_identityUserAssigned
=== PAUSE TestAccApicenterService_identityUserAssigned
=== RUN   TestAccApicenterService_requiresImport
=== PAUSE TestAccApicenterService_requiresImport
=== CONT  TestAccApicenterEnvironment_basic
=== CONT  TestAccApicenterService_basic
=== CONT  TestAccApicenterService_requiresImport
=== CONT  TestAccApicenterEnvironment_requiresImport
=== CONT  TestAccApicenterService_identityUserAssigned
=== CONT  TestAccApicenterEnvironment_complete
--- PASS: TestAccApicenterService_requiresImport (59.53s)
--- PASS: TestAccApicenterService_basic (61.88s)
--- PASS: TestAccApicenterEnvironment_requiresImport (68.58s)
--- PASS: TestAccApicenterEnvironment_complete (73.43s)
--- PASS: TestAccApicenterEnvironment_basic (82.05s)
--- PASS: TestAccApicenterService_identityUserAssigned (83.07s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/apicenter	85.529s

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@favoretti I've looked through the environment resource, a lot of comments I left on that resource should be applied to the api center service resource. Could you please fix those up before I do another pass through?

@favoretti
Copy link
Contributor Author

@favoretti I've looked through the environment resource, a lot of comments I left on that resource should be applied to the api center service resource. Could you please fix those up before I do another pass through?

Thank you! I'll fix it up ASAP.

@favoretti
Copy link
Contributor Author

$ TF_ACC=1 go test -v ./internal/services/apicenter -timeout=1000m
=== RUN   TestAccApiCenterEnvironment_basic
=== PAUSE TestAccApiCenterEnvironment_basic
=== RUN   TestAccApiCenterEnvironment_complete
=== PAUSE TestAccApiCenterEnvironment_complete
=== RUN   TestAccApiCenterEnvironment_requiresImport
=== PAUSE TestAccApiCenterEnvironment_requiresImport
=== RUN   TestAccApiCenterService_basic
=== PAUSE TestAccApiCenterService_basic
=== RUN   TestAccApiCenterService_identityUserAssigned
=== PAUSE TestAccApiCenterService_identityUserAssigned
=== RUN   TestAccApiCenterService_requiresImport
=== PAUSE TestAccApiCenterService_requiresImport
=== CONT  TestAccApiCenterEnvironment_basic
=== CONT  TestAccApiCenterService_basic
=== CONT  TestAccApiCenterService_requiresImport
=== CONT  TestAccApiCenterService_identityUserAssigned
=== CONT  TestAccApiCenterEnvironment_requiresImport
=== CONT  TestAccApiCenterEnvironment_complete
--- PASS: TestAccApiCenterService_requiresImport (140.71s)
--- PASS: TestAccApiCenterEnvironment_requiresImport (152.64s)
--- PASS: TestAccApiCenterService_basic (185.23s)
--- PASS: TestAccApiCenterService_identityUserAssigned (200.40s)
--- PASS: TestAccApiCenterEnvironment_basic (238.41s)
--- PASS: TestAccApiCenterEnvironment_complete (301.25s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/apicenter     303.125s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants