`azurerm_kubernetes_fleet_manager` - Add support for `hub_profile` property #28365

hqhqhqhqhqhqhqhqhqhqhq · 2024-12-22T23:40:30Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

azurerm_kubernetes_fleet_manager - Add support for hub_profile property
The current api version 2024-04-01 now supports the hub_profile property.
This resource is originally auto generated by pandora, but the generated code for api version 2024-04-01 does not work and needs to be implemented manually.

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
I have written new tests for my resource or datasource changes & updated any relevent documentation.
I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
(For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

azurerm_kubernetes_fleet_manager - Add support for hub_profile property

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Related Issue(s)

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

ms-henglu · 2024-12-23T01:33:40Z

internal/services/containers/kubernetes_fleet_manager_resource_test.go

-	})
-}
-
-func TestAccKubernetesFleetManager_update(t *testing.T) {


Please keep this test case to verify if the tags can be updated. You can create a update function to provide the config with updated tags.

stephybun · 2025-01-13T09:49:23Z

internal/services/containers/kubernetes_fleet_manager_resource.go

+			var model KubernetesFleetManagerModel
+			if err := metadata.Decode(&model); err != nil {
 				return fmt.Errorf("decoding: %+v", err)
 			}

+			client := metadata.Client.ContainerService.V20231015.Fleets
 			subscriptionId := metadata.Client.Account.SubscriptionId


Please be mindful of the ordering of calls here, boilerplate code should follow the same pattern and ordering as the rest of the provider.

Suggested change

var model KubernetesFleetManagerModel

if err := metadata.Decode(&model); err != nil {

return fmt.Errorf("decoding: %+v", err)

}

client := metadata.Client.ContainerService.V20231015.Fleets

subscriptionId := metadata.Client.Account.SubscriptionId

client := metadata.Client.ContainerService.V20231015.Fleets

subscriptionId := metadata.Client.Account.SubscriptionId

var model KubernetesFleetManagerModel

if err := metadata.Decode(&model); err != nil {

return fmt.Errorf("decoding: %+v", err)

}

stephybun · 2025-01-13T09:50:44Z

internal/services/containers/kubernetes_fleet_manager_resource.go

 			if !response.WasNotFound(existing.HttpResponse) {
 				return metadata.ResourceRequiresImport(r.ResourceType(), id)
 			}

-			var payload fleets.Fleet
-			r.mapKubernetesFleetManagerResourceSchemaToFleet(config, &payload)
+			fleetResource := &fleets.Fleet{


This is usually called params or payload

stephybun · 2025-01-13T09:52:53Z

internal/services/containers/kubernetes_fleet_manager_resource.go

-	output.Tags = tags.Flatten(input.Tags)
+func flattenFleetHubProfileModel(input *fleets.FleetHubProfile) []FleetHubProfileModel {
+	if input == nil {
+		return nil


We should return an empty hub profile model here

Suggested change

return nil

return []FleetHubProfileModel

github-actions · 2025-02-17T06:03:40Z

This PR is being labeled as "stale" because it has not been updated for 30 or more days.

If this PR is still valid, please remove the "stale" label. If this PR is blocked, please add it to the "Blocked" milestone.

If you need some help completing this PR, please leave a comment letting us know. Thank you!

hqhqhqhqhqhqhqhqhqhqhq · 2025-02-24T07:48:54Z

@stephybun Hi, thanks for review, updated the fix. Ready for rereview.

stephybun

Thanks @hqhqhqhqhqhqhqhqhqhqhq could you resolve the merge conflict and the comment I left in-line? Once that's done this should be good to go.

stephybun · 2025-02-26T09:54:42Z

internal/services/containers/kubernetes_fleet_manager_resource.go

+			properties := resp.Model
+			if resp.Model == nil {
+				return fmt.Errorf("retrieving %s: `model` was nil", *id)
+			}
+			if resp.Model.Properties == nil {
+				return fmt.Errorf("retrieving %s: `properties` was nil", *id)
+			}
+
+			if metadata.ResourceData.HasChange("tags") {
+				properties.Tags = pointer.To(model.Tags)
+			}
+
+			if err := client.CreateOrUpdateThenPoll(ctx, *id, *properties, fleets.DefaultCreateOrUpdateOperationOptions()); err != nil {
+				return fmt.Errorf("updating %s: %+v", *id, err)


We're not patching anything into properties so there's no need to nil check this.

Suggested change

properties := resp.Model

if resp.Model == nil {

return fmt.Errorf("retrieving %s: `model` was nil", *id)

}

if resp.Model.Properties == nil {

return fmt.Errorf("retrieving %s: `properties` was nil", *id)

}

if metadata.ResourceData.HasChange("tags") {

properties.Tags = pointer.To(model.Tags)

}

if err := client.CreateOrUpdateThenPoll(ctx, *id, *properties, fleets.DefaultCreateOrUpdateOperationOptions()); err != nil {

return fmt.Errorf("updating %s: %+v", *id, err)

if resp.Model == nil {

return fmt.Errorf("retrieving %s: `model` was nil", *id)

}

payload := resp.Model

if metadata.ResourceData.HasChange("tags") {

payload.Tags = pointer.To(model.Tags)

}

if err := client.CreateOrUpdateThenPoll(ctx, *id, *payload, fleets.DefaultCreateOrUpdateOperationOptions()); err != nil {

return fmt.Errorf("updating %s: %+v", *id, err)

Done!
Thanks

Sry... did a rebase and made the labels bit weird....
And can't see where I can update those, maybe I don't have permission, can you help check if you can fix the labels?

Update kubernetes_fleet_manager_resource.go Update kubernetes_fleet_manager_resource.go Update kubernetes_fleet_manager_resource_test.go Update kubernetes_fleet_manager.html.markdown Update kubernetes_fleet_manager.html.markdown update update

github-actions bot added enhancement documentation size/XL labels Dec 22, 2024

ms-henglu suggested changes Dec 23, 2024

View reviewed changes

github-actions bot added waiting-response and removed waiting-response labels Dec 23, 2024

hqhqhqhqhqhqhqhqhqhqhq marked this pull request as ready for review January 7, 2025 02:05

hqhqhqhqhqhqhqhqhqhqhq requested a review from a team as a code owner January 7, 2025 02:05

stephybun requested changes Jan 13, 2025

View reviewed changes

github-actions bot assigned stephybun Jan 13, 2025

github-actions bot added the waiting-response label Jan 13, 2025

github-actions bot added the stale label Feb 17, 2025

github-actions bot removed the waiting-response label Feb 24, 2025

github-actions bot removed the stale label Feb 24, 2025

stephybun requested changes Feb 26, 2025

View reviewed changes

hqhqhqhqhqhqhqhqhqhqhq force-pushed the feat/fleet-manager-support-hub-profile branch from e0873e9 to e2d2c21 Compare February 26, 2025 23:46

github-actions bot added dependencies service/storage service/key-vault Key Vault service/dns service/mssql Microsoft SQL Server service/app-service service/event-hubs EventHubs service/traffic-manager service/service-bus service/cosmosdb service/monitor service/redis labels Feb 26, 2025

hqhqhqhqhqhqhqhqhqhqhq force-pushed the feat/fleet-manager-support-hub-profile branch from e2d2c21 to 34d8150 Compare February 26, 2025 23:52

hqhqhqhqhqhqhqhqhqhqhq force-pushed the feat/fleet-manager-support-hub-profile branch from e026d97 to da5a458 Compare February 26, 2025 23:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`azurerm_kubernetes_fleet_manager` - Add support for `hub_profile` property #28365

`azurerm_kubernetes_fleet_manager` - Add support for `hub_profile` property #28365

hqhqhqhqhqhqhqhqhqhqhq commented Dec 22, 2024 •

edited

Loading

ms-henglu Dec 23, 2024

hqhqhqhqhqhqhqhqhqhqhq Dec 23, 2024

stephybun Jan 13, 2025

hqhqhqhqhqhqhqhqhqhqhq Feb 24, 2025

stephybun Jan 13, 2025

hqhqhqhqhqhqhqhqhqhqhq Feb 24, 2025

stephybun Jan 13, 2025

hqhqhqhqhqhqhqhqhqhqhq Feb 24, 2025

github-actions bot commented Feb 17, 2025

hqhqhqhqhqhqhqhqhqhqhq commented Feb 24, 2025

stephybun left a comment

stephybun Feb 26, 2025

hqhqhqhqhqhqhqhqhqhqhq Feb 27, 2025

hqhqhqhqhqhqhqhqhqhqhq Feb 27, 2025

azurerm_kubernetes_fleet_manager - Add support for hub_profile property #28365

Are you sure you want to change the base?

azurerm_kubernetes_fleet_manager - Add support for hub_profile property #28365

Conversation

hqhqhqhqhqhqhqhqhqhqhq commented Dec 22, 2024 • edited Loading

Community Note

Description

PR Checklist

Changes to existing Resource / Data Source

Testing

Change Log

Related Issue(s)

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Feb 17, 2025

hqhqhqhqhqhqhqhqhqhqhq commented Feb 24, 2025

stephybun left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

`azurerm_kubernetes_fleet_manager` - Add support for `hub_profile` property #28365

`azurerm_kubernetes_fleet_manager` - Add support for `hub_profile` property #28365

hqhqhqhqhqhqhqhqhqhqhq commented Dec 22, 2024 •

edited

Loading