New Resource: `azurerm_compute_fleet` #28758

sinbai · 2025-02-12T09:38:32Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

API: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/azurefleet/resource-manager/Microsoft.AzureFleet/stable/2024-11-01/azurefleet.json

Doc: https://learn.microsoft.com/en-us/azure/azure-compute-fleet/overview

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
[] I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
I have written new tests for my resource or datasource changes & updated any relevant documentation.
I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
(For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)


PASS: TestAccComputeFleet_virtualMachineProfileImage_imageFromSharedImageGalleryVersion (1674.34s)
PASS: TestAccComputeFleet_virtualMachineProfileImage_imageFromSharedImageGallery (1618.08s)
PASS: TestAccComputeFleet_virtualMachineProfileImage_imageFromCommunitySharedImageGalleryVersion (1720.16s)
PASS: TestAccComputeFleet_virtualMachineProfileImage_imageFromCommunitySharedImageGallery (1772.22s)
PASS: TestAccComputeFleet_virtualMachineProfileImage_imageFromImageId (688.07s)
PASS: TestAccComputeFleet_virtualMachineProfileImage_imageFromImageSourceReference (583.79s)
PASS: TestAccComputeFleet_virtualMachineProfileExtensions_complete (238.23s)
PASS: TestAccComputeFleet_virtualMachineProfileExtensions_protectedSettingsFromKeyVault (768.25s)
PASS: TestAccComputeFleet_virtualMachineProfileExtensions_basic (233.85s)
PASS: TestAccComputeFleet_virtualMachineProfileExtensions_update (548.34s)
PASS: TestAccComputeFleet_virtualMachineProfileAuth_authMultipleSSHPublicKeys (616.67s)
PASS: TestAccComputeFleet_virtualMachineProfileAuth_authSSHKey (612.78s)
PASS: TestAccComputeFleet_virtualMachineProfileAuth_authPassword (491.86s)
PASS: TestAccComputeFleet_virtualMachineProfileAuth_authEd25519SSHPublicKeys (446.14s)
PASS: TestAccComputeFleet_virtualMachineProfileAuth_authSSHKeyAndPassword (433.36s)
PASS: TestAccComputeFleet_completeExceptVMSS (323.73s)
PASS: TestAccComputeFleet_update (503.19s)
PASS: TestAccComputeFleet_requiresImport (304.98s)
PASS: TestAccComputeFleet_basic (276.35s)
PASS: TestAccComputeFleet_virtualMachineProfileOthers_UserData (544.01s)
PASS: TestAccComputeFleet_virtualMachineProfileOthers_scheduledEvent (550.24s)
PASS: TestAccComputeFleet_virtualMachineProfileOthers_licenseType (560.89s)
PASS: TestAccComputeFleet_virtualMachineProfileOthers_bootDiagnosticEnabled (537.74s)
PASS: TestAccComputeFleet_virtualMachineProfileOthers_galleryApplication (1636.13s)
PASS: TestAccComputeFleet_virtualMachineProfileOthers_securityProfile (409.62s)
PASS: TestAccComputeFleet_virtualMachineProfileOthers_additionalCapabilitiesHibernation (359.61s)
PASS: TestAccComputeFleet_virtualMachineProfileOthers_additionalCapabilitiesUltraSSD (357.57s)
PASS: TestAccComputeFleet_virtualMachineProfileOsProfile_windowsUpdate (774.72s)
PASS: TestAccComputeFleet_virtualMachineProfileOsProfile_windowsComplete (623.81s)
PASS: TestAccComputeFleet_virtualMachineProfileOsProfile_linuxBasic (322.43s)
PASS: TestAccComputeFleet_virtualMachineProfileOsProfile_linuxUpdate (1631.18s)
PASS: TestAccComputeFleet_virtualMachineProfileOsProfile_windowsBasic (360.23s)
PASS: TestAccComputeFleet_virtualMachineProfileOsProfile_linuxComplete (532.94s)
PASS: TestAccComputeFleet_virtualMachineProfileOsDisk_complete (536.28s)
PASS: TestAccComputeFleet_virtualMachineProfileOsDisk_update (1235.23s)
PASS: TestAccComputeFleet_virtualMachineProfileOsDisk_basic (330.43s)
PASS: TestAccComputeFleet_virtualMachineProfileNetwork_basic (379.29s)
PASS: TestAccComputeFleet_virtualMachineProfileNetwork_updateForBaseVirtualMachineProfile (1878.72s)
PASS: TestAccComputeFleet_virtualMachineProfileNetwork_updateForAdditionalLocation (2297.68s)
PASS: TestAccComputeFleet_virtualMachineProfileNetwork_completeForBaseVirtualMachineProfile (836.75s)
PASS: TestAccComputeFleet_virtualMachineProfileNetwork_completeForAdditionalLocation (848.91s)
PASS: TestAccComputeFleet_virtualMachineProfileDataDisk_basic (360.75s)
PASS: TestAccComputeFleet_virtualMachineProfileDataDisk_complete (469.06s)
PASS: TestAccComputeFleet_virtualMachineProfileDataDisk_update (1296.47s)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

azurerm_compute_fleet - new resource

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

ms-zhenhua

Hi @sinbai ,

Thanks for this PR - I've taken a look through and left some comments. If we can fix those up, this should be good to go 👍

ms-zhenhua · 2025-02-17T02:33:03Z

internal/services/computefleet/compute_fleet_resource.go

+			ForceNew: true,
+		},
+
+		"vm_attributes": vmAttributesSchema(),


shall we define the schema inline as it's not reused in other places?

ms-zhenhua · 2025-02-17T02:52:18Z

internal/services/computefleet/compute_fleet_resource.go

+						Optional: true,
+						ForceNew: true,
+						Default:  string(fleets.RegularPriorityAllocationStrategyLowestPrice),
+						ValidateFunc: validation.StringInSlice([]string{


is there a PossibleValuesFor... method for this enum?

ms-zhenhua · 2025-02-17T02:53:08Z

internal/services/computefleet/compute_fleet_resource.go

+						Optional: true,
+						ForceNew: true,
+						Default:  string(fleets.SpotAllocationStrategyPriceCapacityOptimized),
+						ValidateFunc: validation.StringInSlice([]string{


is there a PossibleValuesFor... method for this enum?

ms-zhenhua · 2025-02-17T02:53:23Z

internal/services/computefleet/compute_fleet_resource.go

+						Optional: true,
+						ForceNew: true,
+						Default:  string(fleets.EvictionPolicyDelete),
+						ValidateFunc: validation.StringInSlice([]string{


is there a PossibleValuesFor... method for this enum?

ms-zhenhua · 2025-02-17T06:02:01Z

internal/services/computefleet/compute_fleet_resource.go

+					}
+				}
+
+				if a := model.AdditionalLocationProfile; len(a) > 0 && len(a[0].VirtualMachineProfileOverride) > 0 {


Suggested change

if a := model.AdditionalLocationProfile; len(a) > 0 && len(a[0].VirtualMachineProfileOverride) > 0 {

if additionalLocationProfile := model.AdditionalLocationProfile; len(additionalLocationProfile) > 0 && len(additionalLocationProfile[0].VirtualMachineProfileOverride) > 0 {

ms-zhenhua · 2025-02-20T03:01:20Z

website/docs/r/compute_fleet.html.markdown

+
+* `additional_unattend_content` - (Optional) One or more `additional_unattend_content` blocks as defined above.
+
+* `automatic_updates_enabled` - (Optional) Should the automatic updates of the virtual machines be enabled? Defaults to `true`.


Suggested change

* `automatic_updates_enabled` - (Optional) Should the automatic updates of the virtual machines be enabled? Defaults to `true`.

* `automatic_updates_enabled` - (Optional) Whether to enable the automatic updates of the virtual machines. Defaults to `true`.

ms-zhenhua · 2025-02-20T03:10:39Z

website/docs/r/compute_fleet.html.markdown

+
+* `automatic_updates_enabled` - (Optional) Should the automatic updates of the virtual machines be enabled? Defaults to `true`.
+
+* `bypass_platform_safety_checks_enabled` - (Optional) Should the customer to schedule patching without accidental upgrades be enabled? Defaults to `false`.


same as linux_configuration

ms-zhenhua · 2025-02-20T03:12:15Z

website/docs/r/compute_fleet.html.markdown

+
+* `bypass_platform_safety_checks_enabled` - (Optional) Should the customer to schedule patching without accidental upgrades be enabled? Defaults to `false`.
+
+* `hot_patching_enabled` - (Optional) Should the customers to patch the virtual machines without requiring a reboot be enabled? Defaults to `false`.


Suggested change

* `hot_patching_enabled` - (Optional) Should the customers to patch the virtual machines without requiring a reboot be enabled? Defaults to `false`.

* `hot_patching_enabled` - (Optional) Whether to enable the customers to patch the virtual machines without requiring a reboot. Defaults to `false`.

ms-zhenhua · 2025-02-20T03:12:52Z

website/docs/r/compute_fleet.html.markdown

+
+* `patch_mode` - (Optional)  Specifies the mode of in-guest patching of the virtual machines. Possible values are `AutomaticByOS`, `AutomaticByPlatform` and `Manual`.
+
+* `provision_vm_agent_enabled` - (Optional) Should the virtual machine agent be provisioned on each virtual machine in the Scale Set? Defaults to `true`.


same as linux_configuration

ms-zhenhua · 2025-02-20T03:13:26Z

website/docs/r/compute_fleet.html.markdown

+
+* `time_zone` - (Optional) Specifies the time zone of the windows virtual machine. Changing this forces a new resource to be created.
+
+* `vm_agent_platform_updates_enabled` - (Optional) Should the virtual machine agent platform updates be enabled for the windows virtual machine? Defaults to `false`.


same as linux_configuration

sinbai · 2025-02-21T09:31:53Z

Hi @sinbai ,

Thanks for this PR - I've taken a look through and left some comments. If we can fix those up, this should be good to go 👍

Hi @ms-zhenhua thank you very much for your feedback. I have updated the code, could you please take another look?

ms-zhenhua

Hi @sinbai,

Thank you for the updates. Only one comment left. Others LGTM~

ms-zhenhua · 2025-02-28T07:15:47Z

internal/services/computefleet/compute_fleet_resource.go

@@ -890,29 +876,31 @@ func (r ComputeFleetResource) Update() sdk.ResourceFunc {

 			// API requires `osProfile.adminPassword` when updating resource but the GET API does not return the sensitive data `osProfile.adminPassword`
 			if props := properties.Properties; props != nil {
-				if len(model.VirtualMachineProfile[0].OsProfile[0].LinuxConfiguration) > 0 {
-					if v := props.ComputeProfile.BaseVirtualMachineProfile.OsProfile; v != nil {
+				if v := props.ComputeProfile.BaseVirtualMachineProfile.OsProfile; v != nil {


what if ComputeProfile == nil or BaseVirtualMachineProfile == nil ?

ComputeProfile and BaseVirtualMachineProfile are not pointer types, so I assume they will not be equal to nil.

sinbai · 2025-02-28T09:15:48Z

Hi @sinbai,

Thank you for the updates. Only one comment left. Others LGTM~

Hi @ms-zhenhua thanks for you time and feedback. Could you please take another look?

github-actions bot added documentation dependencies size/XL waiting-response labels Feb 12, 2025

sinbai force-pushed the computefleet/new_resource branch from 11921e3 to 9c5d809 Compare February 12, 2025 10:56

github-actions bot added waiting-response and removed waiting-response labels Feb 12, 2025

sinbai force-pushed the computefleet/new_resource branch from 9c5d809 to b18cc54 Compare February 12, 2025 11:52

github-actions bot added waiting-response and removed waiting-response labels Feb 12, 2025

sinbai force-pushed the computefleet/new_resource branch from b18cc54 to 12b281e Compare February 13, 2025 01:31

github-actions bot added waiting-response and removed waiting-response labels Feb 13, 2025

sinbai force-pushed the computefleet/new_resource branch from 12b281e to 16ace17 Compare February 13, 2025 01:51

github-actions bot removed the waiting-response label Feb 13, 2025

ms-zhenhua suggested changes Feb 20, 2025

View reviewed changes

github-actions bot added service/sentinel service/azure-stack-hci service/data-protection service/dynatrace labels Feb 21, 2025

github-actions bot removed the waiting-response label Feb 21, 2025

sinbai added 2 commits February 26, 2025 13:56

support new resource compute fleet

6d5a00a

fix comments

5f293b9

sinbai force-pushed the computefleet/new_resource branch from 3e24366 to 5f293b9 Compare February 26, 2025 06:46

ms-zhenhua suggested changes Feb 28, 2025

View reviewed changes

github-actions bot added the waiting-response label Feb 28, 2025

github-actions bot removed the waiting-response label Feb 28, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Resource: `azurerm_compute_fleet` #28758

New Resource: `azurerm_compute_fleet` #28758

sinbai commented Feb 12, 2025 •

edited

Loading

ms-zhenhua left a comment

ms-zhenhua Feb 17, 2025

sinbai Feb 21, 2025

ms-zhenhua Feb 17, 2025

sinbai Feb 21, 2025

ms-zhenhua Feb 17, 2025

sinbai Feb 21, 2025

ms-zhenhua Feb 17, 2025

sinbai Feb 21, 2025

ms-zhenhua Feb 17, 2025

sinbai Feb 21, 2025

ms-zhenhua Feb 20, 2025

sinbai Feb 21, 2025

ms-zhenhua Feb 20, 2025

sinbai Feb 21, 2025

ms-zhenhua Feb 20, 2025

sinbai Feb 21, 2025

ms-zhenhua Feb 20, 2025

sinbai Feb 21, 2025

ms-zhenhua Feb 20, 2025

sinbai Feb 21, 2025

sinbai commented Feb 21, 2025

ms-zhenhua left a comment

ms-zhenhua Feb 28, 2025

sinbai Feb 28, 2025

sinbai commented Feb 28, 2025

	if a := model.AdditionalLocationProfile; len(a) > 0 && len(a[0].VirtualMachineProfileOverride) > 0 {
	if additionalLocationProfile := model.AdditionalLocationProfile; len(additionalLocationProfile) > 0 && len(additionalLocationProfile[0].VirtualMachineProfileOverride) > 0 {


		* `additional_unattend_content` - (Optional) One or more `additional_unattend_content` blocks as defined above.

		* `automatic_updates_enabled` - (Optional) Should the automatic updates of the virtual machines be enabled? Defaults to `true`.


		* `automatic_updates_enabled` - (Optional) Should the automatic updates of the virtual machines be enabled? Defaults to `true`.

		* `bypass_platform_safety_checks_enabled` - (Optional) Should the customer to schedule patching without accidental upgrades be enabled? Defaults to `false`.


		* `bypass_platform_safety_checks_enabled` - (Optional) Should the customer to schedule patching without accidental upgrades be enabled? Defaults to `false`.

		* `hot_patching_enabled` - (Optional) Should the customers to patch the virtual machines without requiring a reboot be enabled? Defaults to `false`.

	* `hot_patching_enabled` - (Optional) Should the customers to patch the virtual machines without requiring a reboot be enabled? Defaults to `false`.
	* `hot_patching_enabled` - (Optional) Whether to enable the customers to patch the virtual machines without requiring a reboot. Defaults to `false`.


		* `patch_mode` - (Optional) Specifies the mode of in-guest patching of the virtual machines. Possible values are `AutomaticByOS`, `AutomaticByPlatform` and `Manual`.

		* `provision_vm_agent_enabled` - (Optional) Should the virtual machine agent be provisioned on each virtual machine in the Scale Set? Defaults to `true`.


		* `time_zone` - (Optional) Specifies the time zone of the windows virtual machine. Changing this forces a new resource to be created.

		* `vm_agent_platform_updates_enabled` - (Optional) Should the virtual machine agent platform updates be enabled for the windows virtual machine? Defaults to `false`.

New Resource: azurerm_compute_fleet #28758

Are you sure you want to change the base?

New Resource: azurerm_compute_fleet #28758

Conversation

sinbai commented Feb 12, 2025 • edited Loading

Community Note

Description

PR Checklist

Changes to existing Resource / Data Source

Testing

Change Log

ms-zhenhua left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sinbai commented Feb 21, 2025

ms-zhenhua left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sinbai commented Feb 28, 2025

New Resource: `azurerm_compute_fleet` #28758

New Resource: `azurerm_compute_fleet` #28758

sinbai commented Feb 12, 2025 •

edited

Loading