azurerm_role_management_policy - notification_rules are no longer Optional/Computed and removing the block will reset them back to the default values provided by Azure
#28877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… notification_rules
github-actions
bot
added
documentation
service/authorization
size/XL
waiting-response
labels
stephybun
reviewed
Feb 27, 2025
| `, r.resourceGroupTemplate(data), data.RandomString) | ||
| } | ||
|
|
||
| func (r RoleManagementPolicyResource) resourceGroupUpdateUpdateRemovedNestedNotificationRules(data acceptance.TestData) string { |
There was a problem hiding this comment.
Suggested change
| func (r RoleManagementPolicyResource) resourceGroupUpdateUpdateRemovedNestedNotificationRules(data acceptance.TestData) string { | |
| func (r RoleManagementPolicyResource) resourceGroupRemovedNestedNotificationRules(data acceptance.TestData) string { |
| * `notification_rules` - (Optional) A `notification_rules` block as defined below. | ||
|
|
||
| * ~> **NOTE:** The default notification rules provided by Azure are not set into state. Removing the `notification_rules` block or any of the nested blocks for `notification_rules` will reset them back to the default values for those rules. |
There was a problem hiding this comment.
Suggested change
| * ~> **NOTE:** The default notification rules provided by Azure are not set into state. Removing the `notification_rules` block or any of the nested blocks for `notification_rules` will reset them back to the default values for those rules. | |
| * ~> **Note:** The default notification rules provided by Azure are not set into state. Removing the `notification_rules` block or any of the nested blocks for `notification_rules` will reset them back to the default values for those rules. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents the default notification rules from being set into state.
This is to get around a recurring issue when removing an Optional/Computed block from the config file and Terraform leaving the block as it is currently in state instead of sending a request to remove the block to the api.
By not setting the default values into state, we have much finer control over when to update
notification_rulesand have the ability to reset those values back to the defaults Azure initially had them as