Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: New Resource and Data Source: azurerm_nginx_dataplane_apikey #28919

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dylan-way
Copy link

@dylan-way dylan-way commented Feb 28, 2025

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Adds support for a new Resource and Data source, azurerm_nginx_dataplane_apikey. This is a subresource of NGINX deployments that allows the user to create a Dataplane API Key which is used to make requests against their deployment's dataplane API.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)
=== RUN   TestAccDataplaneAPIKeyDataSource_basic
=== PAUSE TestAccDataplaneAPIKeyDataSource_basic
=== RUN   TestAccDataplaneAPIKeyResource_basic
=== PAUSE TestAccDataplaneAPIKeyResource_basic
=== RUN   TestAccDataplaneAPIKeyResource_complete
=== PAUSE TestAccDataplaneAPIKeyResource_complete
=== RUN   TestAccDataplaneAPIKeyResource_update
=== PAUSE TestAccDataplaneAPIKeyResource_update
=== RUN   TestAccDataplaneAPIKeyResource_requiresImport
=== PAUSE TestAccDataplaneAPIKeyResource_requiresImport
=== CONT  TestAccDataplaneAPIKeyDataSource_basic
=== CONT  TestAccDataplaneAPIKeyResource_requiresImport
=== CONT  TestAccDataplaneAPIKeyResource_complete
=== CONT  TestAccDataplaneAPIKeyResource_basic
=== CONT  TestAccDataplaneAPIKeyResource_update
--- PASS: TestAccDataplaneAPIKeyResource_requiresImport (419.70s)
--- PASS: TestAccDataplaneAPIKeyResource_complete (429.31s)
--- PASS: TestAccDataplaneAPIKeyResource_basic (444.81s)
--- PASS: TestAccDataplaneAPIKeyDataSource_basic (459.90s)
--- PASS: TestAccDataplaneAPIKeyResource_update (464.31s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/nginx	466.561s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Adds support for a new Resource and Data source, azurerm_nginx_dataplane_apikey.
This is a subresource of NGINX deployments that allows the user to create a
Dataplane API Key which is used to make requests against their deployment's
dataplane API.
@dylan-way dylan-way force-pushed the nginxaas-apikey-management branch from 6865cbf to e8a2ffb Compare February 28, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant