Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_key_vault_secret: fix empty check for expiration in CustomizeDiff #28920

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

wuxu92
Copy link
Contributor

@wuxu92 wuxu92 commented Feb 28, 2025

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

If the expiraion is dynamic value, it will always be empty in plan stage, This PR is to fix this issue in CustomizeDiff.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Because this is for a forceNew logic and currently AccTest cannot cover the case. So I only add a test to update the expiration field.

--- PASS: TestAccKeyVaultSecret_updateExpiration (1204.60s)
PASS

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #28914

@wuxu92 wuxu92 requested a review from a team as a code owner February 28, 2025 20:50
@github-actions github-actions bot added size/S and removed size/XS labels Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_key_vault_secret forces replacement if expiration_date is not known until apply
1 participant