Revert "Etag support for ACM service perimeters" #20691
Merged
+3
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[upstream:87f392596aa1431322e8f341011561e171e2329f] Signed-off-by: Modular Magician <[email protected]>
c2thorn
pushed a commit
that referenced
this pull request
Dec 13, 2024
[upstream:87f392596aa1431322e8f341011561e171e2329f] Signed-off-by: Modular Magician <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts GoogleCloudPlatform/magic-modules#12363
Unfortunately, we'd like to revert this change and then try again probably in early January with a new approach for perimeter etags. We have ideas on this but for now we think reverting this change will ensure customers upgrading to the next released version aren't broken.
The broken scenario is when there are perimeters from the same policy in separate google_access_context_manager_service_perimeter resources. Customers with multiple perimeters in a single google_access_context_manager_service_perimeters resource would be fine.
Currently, perimeter etags are generated at the policy level (the parent entity). So, when the first PATCH request is sent for updating perimeter 1, then the etag saved in the Terraform plan for the other perimeters is no longer valid. Those updates will fail.
Derived from GoogleCloudPlatform/magic-modules#12568