Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sync resource in HCP Vault Secrets #1196

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

rodrigo-hcp
Copy link
Contributor

@rodrigo-hcp rodrigo-hcp commented Jan 30, 2025

Test scenarios

  • Import an app with one or more syncs that are unknown to the local TF state and then setting an an empty sync_names: plan will warn of removal of syncs from app.
  • Validates that a config block must be present in the sync resource
  • Importing a sync works
  • Adding or removing one or more syncs from app works

🛠️ Description

🏗️ Acceptance tests

  • Are there any feature flags that are required to use this functionality?
  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccVaultSecretsResourceSync'

...

@rodrigo-hcp rodrigo-hcp self-assigned this Jan 30, 2025
@rodrigo-hcp rodrigo-hcp force-pushed the new-sync-resource branch 3 times, most recently from f563a43 to 76017a2 Compare February 1, 2025 01:05
@rodrigo-hcp rodrigo-hcp marked this pull request as ready for review February 1, 2025 01:22
@rodrigo-hcp rodrigo-hcp requested review from a team as code owners February 1, 2025 01:22
@rodrigo-hcp rodrigo-hcp force-pushed the new-sync-resource branch 2 times, most recently from 917055f to 4d3e497 Compare February 4, 2025 20:23
@rodrigo-hcp rodrigo-hcp marked this pull request as draft February 5, 2025 22:01
pmmukh
pmmukh previously approved these changes Feb 6, 2025
Copy link
Contributor

@pmmukh pmmukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would rec a 2nd review, not well versed in TFP thing, but overall looks great to me!

@rodrigo-hcp rodrigo-hcp force-pushed the new-sync-resource branch 2 times, most recently from fef2586 to 9f180b9 Compare February 13, 2025 20:12
@rodrigo-hcp rodrigo-hcp marked this pull request as ready for review February 19, 2025 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants