generated from hashicorp/terraform-provider-scaffolding
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for sync resource in HCP Vault Secrets #1196
Open
rodrigo-hcp
wants to merge
16
commits into
main
Choose a base branch
from
new-sync-resource
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f563a43
to
76017a2
Compare
76017a2
to
6b2eafb
Compare
dhuckins
reviewed
Feb 3, 2025
917055f
to
4d3e497
Compare
4d3e497
to
ae2358f
Compare
pmmukh
previously approved these changes
Feb 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would rec a 2nd review, not well versed in TFP thing, but overall looks great to me!
b239121
to
acaae18
Compare
maxcoulombe
reviewed
Feb 7, 2025
maxcoulombe
reviewed
Feb 7, 2025
maxcoulombe
reviewed
Feb 7, 2025
3aaead1
to
8fd7739
Compare
c73cbba
to
92ac02f
Compare
…cs from existing app (while preserving the app)
fef2586
to
9f180b9
Compare
maxcoulombe
reviewed
Feb 13, 2025
9f180b9
to
5648962
Compare
5648962
to
7aa1591
Compare
614aade
to
38c2cea
Compare
3bc58ab
to
c6e9699
Compare
50b7518
to
3c58b56
Compare
3c58b56
to
ccceb56
Compare
maxcoulombe
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test scenarios
sync_names
:plan
will warn of removal of syncs from app.sync
resource🛠️ Description
🏗️ Acceptance tests
Output from acceptance testing:
$ make testacc TESTARGS='-run=TestAccVaultSecretsResourceSync' ...