-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support of PATCH method #472
base: main
Are you sure you want to change the base?
Conversation
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
I know it's not part of the RFC7231 but it's really needed. (Also, I think PUT needs to be added later on too). |
Hi @ziflex. I'm cautious about expanding the "read-only So the constraint exists to make it easy for practitioners to do the right thing. |
@bbasata While I respect your intentions to encourage people to do the right thing, the reality is far from being a perfect place. In my particular case, the API I need to use this module for is a 3rd party service I do not have access to and, alas, they use the PATCH method for certain operations. Also, this is an utility module, and adding such restrictions seems counterproductive to me. Why not to keep it simple and let people do their thing? |
Got it. I'm certainly curious -- would you tell me more about the problem you're solving? What's the purpose of the PATCH operation? |
Sure. The 3rd party service is Auth0. |
This pull request includes changes to add support for the
PATCH
HTTP method in the HTTP data source. The most important changes include updating the documentation, modifying the schema to include thePATCH
method, and adding a test for the new method.Documentation Updates:
PATCH
.Code Updates:
PATCH
method in the HTTP data source.Testing:
PATCH
method in the HTTP data source.