-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add tfe_organization_token ephemeral resource #1616
feat: add tfe_organization_token ephemeral resource #1616
Conversation
56f658d
to
0dd4231
Compare
f514efb
to
bad59a3
Compare
089e31b
to
8518b38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a release note about this new ephemeral resource? I had forgotten to do that for the agent token. But I plan to include it in my upcoming PR.
website/docs/ephemeral-resources/organization_token.html.markdown
Outdated
Show resolved
Hide resolved
Addressed in 38b2374. |
The changes look good! Do the tests need to be updated? |
9288eb6
to
690f991
Compare
|
||
Terraform ephemeral resource for managing a TFE organization token. This | ||
resource is used to generate a new organization token that is guaranteed not to | ||
be written to state. Since organization tokens are singleton resources, using this ephemeral resource will replace any existing organization token. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
be written to state. Since organization tokens are singleton resources, using this ephemeral resource will replace any existing organization token. | |
be written to state. Since organization tokens are singleton resources, using this ephemeral resource will replace any existing organization token, including those managed by `tfe_organization_token`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in 93f913b.
|
||
The following arguments are required: | ||
|
||
* `organization` - (Required) Name of the organization. If omitted, organization must be defined in the provider config. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is optional because it probably can use provider config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, addressed in 93f913b.
ebe9b29
to
6f670d6
Compare
Description
Allow users to create an ephemeral resource for
tfe_organization_token
, so that the org token is not stored in the Terraform state file and can be handled securely and temporarily during Terraform operations.Remember to:
Testing plan
Then init and apply the configuration.
The state file should not include the ephemeral resource.
Output from acceptance tests
Please run applicable acceptance tests locally and include the output here. See testing.md to learn how to run acceptance tests.
If you are an external contributor, your contribution(s) will first be reviewed before running them against the project's CI pipeline.