Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apt proxy #168

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Apt proxy #168

merged 3 commits into from
Sep 9, 2024

Conversation

tauhid621
Copy link
Contributor

Background

This PR adds proxy details to the /etc/apt/apt.conf file so that apt can work with proxies.

If not provided, apt-get --assume-yes update step fails with error Unsupported proxy configured: ip://3128

Screenshot 2024-09-05 at 4 50 21 PM

How has this been tested?

Updated the module and deployed in azure with proxy. TFE was installed after this

Did you add a new setting?

No

@tauhid621 tauhid621 requested a review from a team as a code owner September 6, 2024 07:35
@kkavish
Copy link

kkavish commented Sep 6, 2024

@tauhid621 if I understand correctly, this is so that apt-get could work for VMs/containers deployed behind a proxy and thus don't have direct access to internet?

@tauhid621
Copy link
Contributor Author

@kkavish Yes. apt-get for some reason is not working with the default proxy settings. One way to fix it is to use /etc/apt/apt.conf with proxy information

@kkavish
Copy link

kkavish commented Sep 6, 2024

LGTM!

@hamzahashicorp
Copy link

LGTM, but where is this final being templated? Is the proxy_ip being set anywhere, maybe in a tfvars file? I'm not seeing a default value being set other than the ones in the tpl files

@tauhid621
Copy link
Contributor Author

@hamzahashicorp The files are being templated in the main.tf file of the module.
The default values of proxy ip and port are null.

@nikolasrieble nikolasrieble merged commit b5dafbf into hashicorp:main Sep 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants