Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix https proxy address for apt #169

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Fix https proxy address for apt #169

merged 1 commit into from
Sep 18, 2024
+4 −4

Conversation

tauhid621
Copy link
Contributor

Background

This PR fixes the https proxy address for apt.
The address should have http instead of https. This was added by mistake in previous PR

How has this been tested?

End to end test scenario of TFE behind proxy.

Did you add a new setting?

No

@tauhid621 tauhid621 requested a review from a team as a code owner September 11, 2024 05:31
@tauhid621 tauhid621 removed the request for review from a team September 11, 2024 05:41
nikolasrieble
nikolasrieble approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@nikolasrieble nikolasrieble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for clarification

@nikolasrieble nikolasrieble merged commit 1cde51b into main Sep 18, 2024
4 checks passed
@nikolasrieble nikolasrieble deleted the tauhid621/api_proxy_fix branch September 18, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkavish kkavish kkavish approved these changes

@nikolasrieble nikolasrieble nikolasrieble approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tauhid621 @nikolasrieble @kkavish