runtime container engine config http https port fix #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update with upstream
… value. Breaks deployment.
…d - add restart modes and max number of restarts.
…_allow_container_restart fix: runtime_container_engine_config - allow container to be restarte…
fix: tfe_init - support for self signed certs for internal services
…stom_ssl_key_setup
…_custom_ssl_key_setup chg: runtime_container_engine_config - add support for custom ssl key…
…tp_https_port_fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
If the http and https ports are left blank the deployment fails. This will ensure that deployment does not fail when leaving the variables as empty or null.
How has this been tested?
For dev and prod TFE instances in AWS
Did you add a new setting?
No
This PR makes me feel