Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HA Postgres configuration #166

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

miguelhrocha
Copy link

Background

This PR adds the environment configuration for enabling the experimental feature: "reconnect database on failure". I need to introduce this to our modules to facilitate testing with real infra.

@miguelhrocha miguelhrocha requested a review from a team as a code owner August 5, 2024 10:24
@@ -76,6 +76,24 @@ variable "disk_path" {
type = string
}

variable "database_reconnect_enabled" {
Copy link
Contributor

@nikolasrieble nikolasrieble Aug 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💭 Instead of having to extend the module every time, what do you think about allowing to pass arbitrary env variables? That would shorten the development cycle. We could still promote env variables to proper variables later.

@nikolasrieble nikolasrieble self-requested a review September 4, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants