Skip to content

Make the JSON view for init commands use defaults from the hclog package #37840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
+15 −14
Draft

Make the JSON view for init commands use defaults from the hclog package #37840

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4eb7c99
Refactor `(v *InitJSON) Output` to use defaults that come from the hc…
SarahFrench Oct 29, 2025
7e01502
Update formatting, add comment
SarahFrench Oct 29, 2025
113c455
Update code comment
SarahFrench Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 15 additions & 14 deletions internal/command/views/init.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,8 @@
package views

import (
"encoding/json"
"fmt"
"strings"
"time"

"github.com/hashicorp/terraform/internal/command/arguments"
"github.com/hashicorp/terraform/internal/tfdiags"
Expand Down Expand Up @@ -97,18 +95,21 @@ func (v *InitJSON) Output(messageCode InitMessageCode, params ...any) {
return
}

current_timestamp := time.Now().UTC().Format(time.RFC3339)
json_data := map[string]string{
"@level": "info",
"@message": preppedMessage,
"@module": "terraform.ui",
"@timestamp": current_timestamp,
"type": "init_output",
"message_code": string(messageCode),
}

init_output, _ := json.Marshal(json_data)
v.view.view.streams.Println(string(init_output))
// Logged data includes by default:
// @level as "info"
// @module as "terraform.ui" (See NewJSONView)
// @timestamp formatted in the default way
//
// In the method below we:
// * Set @message as the first argument value
// * Annotate with extra data:
// "type":"init_output"
// "message_code":"<value>"
v.view.log.Info(
preppedMessage,
"type", "init_output",
"message_code", string(messageCode),
)
}

func (v *InitJSON) LogInitMessage(messageCode InitMessageCode, params ...any) {
Expand Down
Loading