feat: rotating client.log #48
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Info
Closes hashtopolis/server#667
Switches the client log (
client.log) to use aRotatingFileHandlerinstead of just a raw open file handle.Adds two CLI arguments to adjust log rotation behavior, with sane defaults
--max-log-size--max-log-backupsSuppose could make make it opt-in instead, if desired, and only use this new rotating option if
--rotating-loggeror somesuch was also passed. This way default functionality satisfies backwards compatibility such that not passing any new arguments would result in theclient.logjust growing indefinitely via the single rawopen()handler (lmk if thats desired and can make that change)Testing
I built a
hashtopolis.zipagent bundle and synced it to our setup and configured to use it and nothing broke that I saw ¯_(ツ)_/¯. Log rotated as expected and kept specified number of backups.