Implemented helper for password reset #1043
Conversation
…and a user we are still missing a sendmail agent on the docker setup to make sending emails working
| @@ -25,6 +25,15 @@ ENV HASHTOPOLIS_LOG_PATH=${HASHTOPOLIS_PATH}/log | |||
| ENV HASHTOPOLIS_CONFIG_PATH=${HASHTOPOLIS_PATH}/config | |||
| ENV HASHTOPOLIS_BINARIES_PATH=${HASHTOPOLIS_PATH}/binaries | |||
|
|
|||
| ENV HASHTOPOLIS_SSMTP_ENABLE=0 | |||
There was a problem hiding this comment.
I think it is a little bit confusing to put all the environment variabels here instead out of the .env file. since the env.example file now also have these environment variables but from there they are never used.
Personally I would say an even better solution would be to instead of using environment variables, is to create a ssmtp.conf template here and let the user fill that in. Then in the docker file it can be transferred like "COPY ssmtp-template.conf /etc/ssmtp/ssmtp.conf". That way the user has more flexibility in setting up the ssmtp configuration and is not limited to the few environment variables.
| @@ -32,6 +32,7 @@ public function getFormFields(): array { | |||
| public function actionPost($data): array|null { | |||
| UserUtils::userForgotPassword($data[User::USERNAME], $data[User::EMAIL]); | |||
|
|
|||
| # TODO: Check how to handle custom return messages that are not object, probably we want that to be in some kind of standardized form. | |||
There was a problem hiding this comment.
We now have a standardized way so this comment can be removed
| @@ -10,6 +10,9 @@ for path in ${paths[@]}; do | |||
| fi | |||
| done | |||
|
|
|||
| echo "Running required root setups." | |||
| sudo -E /usr/local/bin/second-level-docker-entry.sh | |||
There was a problem hiding this comment.
For me this will give the following errors:
sudo: a terminal is required to read the password; either use the -S option to read from standard input or configure an askpass helper
sudo: a password is required
I think the reason for this error is because the user that executes entrypoint script is vscode and not www-data
| @@ -77,6 +87,11 @@ COPY --from=preprocess /HEA[D] ${HASHTOPOLIS_DOCUMENT_ROOT}/../.git/ | |||
| COPY composer.json ${HASHTOPOLIS_DOCUMENT_ROOT}/../ | |||
| RUN composer install --working-dir=${HASHTOPOLIS_DOCUMENT_ROOT}/.. | |||
|
|
|||
| RUN echo "www-data ALL=NOPASSWD:SETENV: /usr/local/bin/second-level-docker-entry.sh" >> /etc/sudoers.d/10_docker | |||
There was a problem hiding this comment.
Like mentioned, I think www-data here should be replaced by vscode. But im not 100% sure
Helper added for non-authenticated requests for a reset of a users password.
This function requires emails to be sent, therefore the email docker configuration is included as well (which for example would also be used by email notifications).
As a simple sendmail utility, ssmtp is used whose configuration is now included in docker-compose and the example env as well.