Replacing custom "log" function with system.log that comes with durandal for notifier.js#1
Open
AshanFernando wants to merge 1 commit intohasith:masterfrom
AshanFernando:master
Open
Replacing custom "log" function with system.log that comes with durandal for notifier.js#1AshanFernando wants to merge 1 commit intohasith:masterfrom AshanFernando:master
AshanFernando wants to merge 1 commit intohasith:masterfrom
AshanFernando:master
Conversation
…dal for notifier.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a suggestion to use a unique logger through out the system. Only replaced custom "log" in notifier.js and since durandal already has a logger built in (system.log), it would be easier to use it. When it comes to production, logging can be globally switched off and I hope durandal optimizer can remove the logging from the script when optimizing.