Skip to content

Commit

Permalink
Make the subject URL optional
Browse files Browse the repository at this point in the history
This goes against the documentation at
https://docs.github.com/en/rest/activity/notifications but it seems to be
required in order to handle certain types of notifications.
  • Loading branch information
magthe authored and maralorn committed Sep 24, 2024
1 parent 6b9716c commit 9fa6bde
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/GitHub/Data/Activities.hs
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ instance FromJSON RepoStarred where

data Subject = Subject
{ subjectTitle :: !Text
, subjectURL :: !URL
, subjectURL :: !(Maybe URL)
, subjectLatestCommentURL :: !(Maybe URL)
-- https://developer.github.com/v3/activity/notifications/ doesn't indicate
-- what the possible values for this field are.
Expand Down

0 comments on commit 9fa6bde

Please sign in to comment.