Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NSet for both recursive and non-recursive sets #500

Merged
merged 1 commit into from
Jul 25, 2019

Conversation

infinisil
Copy link
Contributor

Simplifies the AST, I suggested this in #377

To mention is that I didn't change the use of the shorthand functions mkRecSet and mkNonRecSet for convenience.

I opted to use a new type

data NRecordType = NNonRecursive | NRecursive

to represent recursive/non-recursiveness. Alternatively a Bool could be used, but I like how self-documenting this type is. Constructor names are debatable, NNonRec/NRec sounds good too.

This is a backwards-incompatible change.

@infinisil
Copy link
Contributor Author

Ping?

@jwiegley jwiegley merged commit 82b2d8a into haskell-nix:master Jul 25, 2019
@infinisil
Copy link
Contributor Author

Cool thanks :)

@infinisil infinisil deleted the combined-rec-nonrec-sets branch July 26, 2019 14:44
@sjakobi sjakobi mentioned this pull request Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants