Replace undefined with more descriptive error #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasabel
reviewed
Dec 29, 2024
brandonchinn178
force-pushed
the
patch-1
branch
from
ef34612 to
5aba694
Compare
|
@andreasabel How's that? |
|
Thanks! Somehow the testsuite fails:
|
|
Hopefully adding the missing |
|
https://github.com/haskell/alex/actions/runs/12548981514/job/34989207762?pr=262#step:9:111
|
|
Released as 3.5.2.0. |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Jan 13, 2025
## Changes in 3.5.2.0 * Use `byteSwap16#` and `byteSwap32#` on big-endian architectures instead of handrolling the implementation ([PR #260](haskell/alex#260)). * More descriptive error in `alexScan`; inline `alexScanUser` ([PR #262](haskell/alex#262)). * Tested with GHC 8.0 - 9.12.1.
hubot
pushed a commit
to ghc/ghc
that referenced
this pull request
Jan 21, 2025
This INLINE pragma for alexScanUser was added in 9.12, but then I ported the change to alex in 3.5.2.0 (haskell/alex#262). I didn't realize that GHC errors on duplicate INLINE pragmas, so this ended up being a breaking change. This change should be backported into 9.12
hubot
pushed a commit
to ghc/ghc
that referenced
this pull request
Jan 22, 2025
This INLINE pragma for alexScanUser was added in 9.12, but then I ported the change to alex in 3.5.2.0 (haskell/alex#262). I didn't realize that GHC errors on duplicate INLINE pragmas, so this ended up being a breaking change. This change should be backported into 9.12
hubot
pushed a commit
to ghc/ghc
that referenced
this pull request
Jan 23, 2025
This INLINE pragma for alexScanUser was added in 9.12, but then I ported the change to alex in 3.5.2.0 (haskell/alex#262). I didn't realize that GHC errors on duplicate INLINE pragmas, so this ended up being a breaking change. This change should be backported into 9.12
hubot
pushed a commit
to ghc/ghc
that referenced
this pull request
Jan 24, 2025
This INLINE pragma for alexScanUser was added in 9.12, but then I ported the change to alex in 3.5.2.0 (haskell/alex#262). I didn't realize that GHC errors on duplicate INLINE pragmas, so this ended up being a breaking change. This change should be backported into 9.12
hubot
pushed a commit
to ghc/ghc
that referenced
this pull request
Jan 24, 2025
This INLINE pragma for alexScanUser was added in 9.12, but then I ported the change to alex in 3.5.2.0 (haskell/alex#262). I didn't realize that GHC errors on duplicate INLINE pragmas, so this ended up being a breaking change. This change should be backported into 9.12
hubot
pushed a commit
to ghc/ghc
that referenced
this pull request
Jan 25, 2025
This INLINE pragma for alexScanUser was added in 9.12, but then I ported the change to alex in 3.5.2.0 (haskell/alex#262). I didn't realize that GHC errors on duplicate INLINE pragmas, so this ended up being a breaking change. This change should be backported into 9.12
hubot
pushed a commit
to ghc/ghc
that referenced
this pull request
Jan 25, 2025
This INLINE pragma for alexScanUser was added in 9.12, but then I ported the change to alex in 3.5.2.0 (haskell/alex#262). I didn't realize that GHC errors on duplicate INLINE pragmas, so this ended up being a breaking change. This change should be backported into 9.12
hubot
pushed a commit
to ghc/ghc
that referenced
this pull request
Jan 25, 2025
This INLINE pragma for alexScanUser was added in 9.12, but then I ported the change to alex in 3.5.2.0 (haskell/alex#262). I didn't realize that GHC errors on duplicate INLINE pragmas, so this ended up being a breaking change. This change should be backported into 9.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this error is thrown, it's difficult to debug: https://gitlab.haskell.org/ghc/ghc/-/issues/25609