Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitLab CI: Add aarch64-linux-deb{10,11} #8851

Merged
merged 3 commits into from
Mar 21, 2023

Conversation

chreekat
Copy link
Collaborator

@chreekat chreekat commented Mar 14, 2023

GitLab pipeline: pipeline status

Makes headway on #8849

Kudos to @hasufell for making this possible with a fix to GHCUp

@Mikolaj
Copy link
Member

Mikolaj commented Mar 14, 2023

ghc-prerelease jobs failing is normal right now. We are working on this.

Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mikolaj
Copy link
Member

Mikolaj commented Mar 15, 2023

@mergify backport 3.10

@mergify
Copy link
Contributor

mergify bot commented Mar 15, 2023

backport 3.10

✅ Backports have been created

@Mikolaj
Copy link
Member

Mikolaj commented Mar 17, 2023

Let me set the label, not to distract the author.

@Mikolaj Mikolaj added the merge me Tell Mergify Bot to merge label Mar 17, 2023
@chreekat
Copy link
Collaborator Author

@Mikolaj I assumed it was a maintainer responsibility to do whatever action is required to merge a PR. :) If it's up to the author, are the steps documented somewhere?

@Mikolaj
Copy link
Member

Mikolaj commented Mar 17, 2023

@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Mar 19, 2023
@ulysses4ever
Copy link
Collaborator

@chreekat @Mikolaj The merge process is stuck for some reason. I suggest to rebase on master. Can be done from the web with a comment @Mergify rebase on this thread.

@chreekat
Copy link
Collaborator Author

I'll give it a shot:

@mergify rebase

@chreekat
Copy link
Collaborator Author

@Mikolaj thanks for the link! I like the policy. It's just a bit hard to find as a first-time contributor. I don't feel too bad that I didn't read such a long CONTRIBUTING.md from top to bottom :D

@ulysses4ever
Copy link
Collaborator

@chreekat you have to create a comment with exactly that text and nothing else (the bot is silly)

Also, just fyi, PR template references exactly the section about PR guidelines in CONTRIBUTING.md

@Mikolaj
Copy link
Member

Mikolaj commented Mar 20, 2023

@mergify refresh

@mergify
Copy link
Contributor

mergify bot commented Mar 20, 2023

refresh

✅ Pull request refreshed

@chreekat
Copy link
Collaborator Author

PR template references exactly the section about PR guidelines in CONTRIBUTING.md

Does it, though? :)

@Mikolaj
Copy link
Member

Mikolaj commented Mar 20, 2023

Strange, the Queue: Embarked in merge train link says

The merge queue pull request can't be updated
Details:

    Unable to update: user chreekat is unknown.

    Please make sure chreekat has logged in Mergify dashboard.

@ulysses4ever
Copy link
Collaborator

@chreekat you're right: out references some sections but not that one. We should update it!

@Mikolaj indeed, this is the error I saw yesterday. I have no clue what's wrong. But then again, I didn't try to Google it even...

@Mikolaj
Copy link
Member

Mikolaj commented Mar 20, 2023

Let's hope @chreekat can at least rebase via mergify invocation.

@chreekat
Copy link
Collaborator Author

@mergify rebase

@mergify
Copy link
Contributor

mergify bot commented Mar 20, 2023

rebase

❌ Unable to rebase: user chreekat is unknown.

Please make sure chreekat has logged in Mergify dashboard.

@chreekat
Copy link
Collaborator Author

🙈

@ulysses4ever
Copy link
Collaborator

Crap, it looks like Mergify without Premium quickly becomes more and more useless:

My understanding after quick skimming: only admins will be able to rebase their own PRs via Mergify unless you have Premium and can set update_bot_account.

@Mikolaj
Copy link
Member

Mikolaj commented Mar 21, 2023

That would be a very ugly bait and switch. But they say they are going to fix it, so probably unintentional.

@Mikolaj
Copy link
Member

Mikolaj commented Mar 21, 2023

@mergify rebase

@mergify
Copy link
Contributor

mergify bot commented Mar 21, 2023

rebase

✅ Branch has been successfully rebased

@Mikolaj Mikolaj force-pushed the wip/b/aarch64-linux branch from 65cfdd5 to a4693f8 Compare March 21, 2023 07:11
@mergify mergify bot merged commit 3927dd8 into haskell:master Mar 21, 2023
mergify bot added a commit that referenced this pull request Mar 21, 2023
GitLab CI: Add aarch64-linux-deb{10,11} (backport #8851)
@chreekat chreekat deleted the wip/b/aarch64-linux branch August 8, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
continuous-integration merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants