Use randomly structured Set and Map in benchmarks #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is motivated by #1069 (comment). |
|
Effect on benchmarks, GHC 9.10.1: Set ExpandMap ExpandSet operations, Set ExpandSet operations, Map ExpandEdit: I had repeated the Map benchmarks under Set, fixed now. |
meooow25
force-pushed
the
random-set-map-bench
branch
2 times, most recently
from
56f8df1 to
032ab37
Compare
|
👍 The large change for |
meooow25
force-pushed
the
random-set-map-bench
branch
from
032ab37 to
bb1b662
Compare
|
That's correct. To explain the large increases a little more,
Overall I don't see anything unusual, the changes in the numbers are reasonable. |
Trees constructed from [1..n] have a specific structure of perfect binary trees linked together. We shuffle the list so that the tree is generated from repeated insertions instead, which forms a random structure that should be more representative of average use cases. Most benchmarks show an increase in measured times, the amount varying from 10% to 70%. This is expected because the trees are more unbalanced now. A handful of benchmarks show larger increases. These were previously measuring best-case scenarios, which no longer occurs with random trees.
meooow25
force-pushed
the
random-set-map-bench
branch
from
bb1b662 to
ea138a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trees constructed from [1..n] have a specific structure of perfect
binary trees linked together. We shuffle the list so that the tree
is generated from repeated insertions instead, which forms a random
structure that should be more representative of average use cases.
Most benchmarks show an increase in measured times, the amount varying
from 10% to 80%.