Partial fix for #14 #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By the way, as i was diving into the bindings.dsl.h code and also the code of hsc2hs i was wondering why this was written in C. Maybe it makes more sense there to skip the C step and write out the HS file straight from haskell. |
|
The situation with the line numbers seem to be better than as it was. However need support from bindings.dsl.h for printing correct line pragma's see rethab/bindings-dsl#33 |
|
Why wasn't this PR merged? Can i help it somehow? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the line pragma of Special token was dependent on the creation of empty Text tokens (not to be confused with Data.Text). The empty Text tokens create empty sections in the generated .hs file and in generally it's better to let the Special tokens be responsible for it's own line pragma's.
I added state for starttype / stoptype so the line numbers get tracked. The thing was that the C macro for hsc_starttype and the hsc_field to not generated any hs code. All the code is only generated at the hsc_stoptype macro. But the offset in the original hsc file is counted from the line number of the hsc_starttype not hsc_stoptype. This is the main fix for #14